Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for following a tombstone to an unknown room version could be improved #91

Closed
krille-chan opened this issue Jul 15, 2023 · 2 comments
Labels
stale The item is going to be closed soon because of inactivity

Comments

@krille-chan
Copy link
Owner

Description

I was testing a few scenarios of room upgrades to an unknown room versions (in order to see how quickly we could go use new room versions after they're released in Synapse).

To Reproduce

While testing this for the Element clients I figured I should try FluffyChat too, the following scenarios are what I was looking at:

  1. Joining a room
    1. Create a public room on hs1 with room version test
    2. Attempt to join it from hs2
  2. Inviting to a room
    1. Create a room on hs1 with room version test
    2. Send an invite to a user on hs2
    3. Attempt to accept the invite
  3. Room upgrade
    1. Create a public room on hs1 with room version 6
    2. Join the room as user on hs2
    3. Upgrade the room /upgraderoom test on hs1
    4. Attempt to follow the tombstone.
  4. Spaces summary
    1. Create a public room on hs1 with room version test
    2. Create a space and add the above room to it
    3. Send an invite to the space to a user on hs2
    4. Accept the invite
    5. Attempt to explore the space

Note that this somewhat requires hacking a homeserver to have one with an "unknown" room version.

I tested this with FluffyChat web.

Note that I was unable to complete scenarios 1 & 4. (I hadn't used FluffyChat before, but I couldn't figure out if there was a way to join an arbitrary room.)

Scenario 2 completed successfully, the user sees the following:

image

Scenario 3 gave a generic error message would could be more explicit:

image

Additional information:

Let me know if you have any questions!

Copy link

github-actions bot commented Mar 7, 2024

This issue is stale because it has been open for 120 days with no activity.

@github-actions github-actions bot added the stale The item is going to be closed soon because of inactivity label Mar 7, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
AaronDewes pushed a commit to OpenSchulcampusTools/schulchat that referenced this issue Sep 12, 2024
…OverviewController from Message), needs changes in famedlysdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The item is going to be closed soon because of inactivity
Projects
None yet
Development

No branches or pull requests

1 participant