Skip to content

Commit

Permalink
Update and enable embind tests to run with the Closure Compiler
Browse files Browse the repository at this point in the history
This change adds a pass to the embind tests to run them with the Closure
Compiler enabled.

Because embind.test.js will be passed through the Closure Compiler, name-
mangling will occur on unquoted references to embound classes and functions.
However, because embound symbols are exposed via string literals, this results
in a mismatch.

The tests have now been updated so that all references to embound symbols are
referred to by string literals (i.e. object["property"] syntax) instead of just
by name (i.e. object.property syntax).

A set of Closure externs for Underscore were also added, because Underscore
(which is used by the embind test adapter) exposes some symbols by string
literal as well.
  • Loading branch information
rharkeadsk committed Dec 17, 2014
1 parent b7967e6 commit ef73471
Show file tree
Hide file tree
Showing 3 changed files with 1,903 additions and 1,065 deletions.

0 comments on commit ef73471

Please sign in to comment.