New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5.h does not offer a way to call `document.documentElement.requestFullscreen()` #5232

Closed
ghost opened this Issue May 18, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented May 18, 2017

I have encountered a case where calling emscripten_request_fullscreen on my element does not work on Chrome (58) for Android. Investigating, it turns out that the recommended approach[1] is to call document.documentElement.requestFullscreen(). But, I could not find any way to make this call via the Emscripten API. Passing #document as the target does not work, as that results in a call to document.requestFullscreen instead. One possible fix would be to add another alias like #documentElement.

My workaround for now is to use an EM_ASM block to make the call in JavaScript.

thanks!

[1] : https://developers.google.com/web/fundamentals/native-hardware/fullscreen/

@ghost

This comment has been minimized.

ghost commented Aug 21, 2017

I'll go ahead and close this since its easy enough to make the call into JavaScript.

@ghost ghost closed this Aug 21, 2017

@juj

This comment has been minimized.

Collaborator

juj commented Aug 21, 2017

What is document.documentElement? Can you add an id to that element, and then request fullscreen based on that id?

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment