Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Set a tabindex on the canvas #7484
Without it, it cannot be focused, so the user cannot click on it and have the canvas receive events. For example,
Set a value of -1, which just means 'focusable' and does not include it in the tab ordering, which is the same as before.
I'm surprised we didn't notice this before, so perhaps I'm missing something here? The attached testcase is fixed by this PR though, and it seems like something that should work out of the box?
A popular practice is to register key events on
Tabindex affects how one tab cycles across fillable form/text input elements, so canvas will then become one of those elements when a tabindex is given to it.
Looks good to me to add tabindex to default shell, but perhaps the proper fix is to document in