New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify addRunDependency assert #7516

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@Beuc
Contributor

Beuc commented Nov 16, 2018

so the user doesn't get a cryptic "Assertion failed: undefined"

Bonus question: I'm using addRunDependency in Module.preInit to download the base .data files (generated independently). Is that supported somehow else?

Clarify addRunDependency assert
so the user doesn't get a cryptic "Assertion failed: undefined"

@kripken kripken merged commit 9646b6b into kripken:incoming Nov 16, 2018

26 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-upstream Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: test-ab Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen0 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen1 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen3 Your tests passed on CircleCI!
Details
ci/circleci: test-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-browser-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-c Your tests passed on CircleCI!
Details
ci/circleci: test-d Your tests passed on CircleCI!
Details
ci/circleci: test-e Your tests passed on CircleCI!
Details
ci/circleci: test-f Your tests passed on CircleCI!
Details
ci/circleci: test-ghi Your tests passed on CircleCI!
Details
ci/circleci: test-jklmno Your tests passed on CircleCI!
Details
ci/circleci: test-other Your tests passed on CircleCI!
Details
ci/circleci: test-p Your tests passed on CircleCI!
Details
ci/circleci: test-qrst Your tests passed on CircleCI!
Details
ci/circleci: test-sanity Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasmobj2 Your tests passed on CircleCI!
Details
ci/circleci: test-uvwxyz Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kripken

This comment has been minimized.

Owner

kripken commented Nov 16, 2018

Bonus question: I'm using addRunDependency in Module.preInit to download the base .data files (generated independently). Is that supported somehow else?

In general you can just load the JS generated from the file packager, in another script tag. So if addRunDependency isn't an option, perhaps the app can wait on a signal you manage yourself.

I'm not sure though why addRunDependency wouldn't work with pthreads - maybe that's fixable?

@Beuc Beuc deleted the Beuc:patch-1 branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment