Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Stack trace rewriting goes haywire if `error.stack` already accessed #116

Closed
domenic opened this Issue · 0 comments

1 participant

@domenic
Collaborator

In this case, Error.prepareStackTrace is never called, so we never get an array, and getStackFrames ends up returning a string.

Via Q Continuum

@domenic domenic was assigned
@domenic domenic referenced this issue from a commit
@ef4 ef4 Don't mangle stack traces when an exception is seen twice.
It's possible for the same exception to hit two different `end()` points, causing it to pass through the stack trace formatter twice.

On the second pass, `error.stack` is already a string, and the formatter mangles it by inserting newlines after every character.

Fixes #121 and #116. Related: #117.
c2c7353
@domenic domenic closed this
@dfilatov dfilatov referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.