Add a flag for not collecting failed promises #255

Closed
mjackson opened this Issue Apr 4, 2013 · 1 comment

Comments

Projects
None yet
2 participants

mjackson commented Apr 4, 2013

A small optimization might be to add a flag that instructs Q to not collect failed promises. While this behavior is totally useful in development, it can slow things down. @domenic and I discussed this briefly at HTML5 DevConf this week.

@kriskowal Is this something you'd be ok with?

Owner

kriskowal commented Apr 4, 2013

@mjijackson Yeah, I would entertain this.

domenic added a commit that referenced this issue May 18, 2013

Add nice unhandled-rejection tracking API as per #265.
- Closes #244 and closes #245 since `Q.stopUnhandledRejectionTracking()` removes the `process.on("exit", ...)` handler.
- Closes #255 since `Q.stopUnhandledRejectionTracking()` prevents any storage or tracking of unhandled rejections or unhandled rejection reasons.
- Closes #265 via the new `Q.getUnhandledReasons()` and `Q.resetUnhandledRejections()` APIs, which are useful mainly for testing and diagnostics.
- Closes #278 by slightly reordering the code inside `trackRejection`.

@domenic domenic closed this in 9dcf462 May 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment