Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIxed:314] add rule `selector-no-union-class-name` #338

Merged
merged 5 commits into from Jun 29, 2019

Conversation

Projects
None yet
3 participants
@pipopotamasu
Copy link
Contributor

commented Jun 27, 2019

Added new rule to fix #314.

This rule disallow to union class name like this.

@coveralls

This comment has been minimized.

Copy link

commented Jun 27, 2019

Coverage Status

Coverage increased (+0.03%) to 92.22% when pulling a83dc5f on pipopotamasu:issue#314 into f580170 on kristerkari:master.

@pipopotamasu pipopotamasu changed the title [WIP] add `selector-no-union-class-name` [WIP] add rule `selector-no-union-class-name` Jun 27, 2019

@pipopotamasu pipopotamasu changed the title [WIP] add rule `selector-no-union-class-name` [WIP] [FIxed:314] add rule `selector-no-union-class-name` Jun 27, 2019

@pipopotamasu pipopotamasu changed the title [WIP] [FIxed:314] add rule `selector-no-union-class-name` [FIxed:314] add rule `selector-no-union-class-name` Jun 27, 2019

@kristerkari

This comment has been minimized.

Copy link
Owner

commented Jun 27, 2019

Thanks! I'll try to review this asap.

Show resolved Hide resolved src/rules/selector-no-union-class-name/index.js Outdated
Show resolved Hide resolved README.md Outdated

pipopotamasu added some commits Jun 28, 2019

@kristerkari kristerkari merged commit c2875f3 into kristerkari:master Jun 29, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 92.22%
Details
@kristerkari

This comment has been minimized.

Copy link
Owner

commented Jun 29, 2019

Great! Thanks!

@kristerkari

This comment has been minimized.

Copy link
Owner

commented Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.