update image-gallery to 2.10 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristianmandrup
added a commit
that referenced
this pull request
Feb 12, 2013
update image-gallery to 2.10
|
Great! I'm happy you got it fixed. To be honest, I havent used the bootstrap image gallery myself, just thought it would be nice to have it prepackaged and ready for use with Rails in case I (or someone) would need it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why it's incompatible, but with jquery-rails 2.1.4 and bootstrap-sass 2.2.2.0 image-gallery 2.8 doesn't work and firebug doesn't show any error.
From the patch I guess that could be something related to this, but I don't know:
With this patch I could make it work with the instructions in README.