New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset depends on 'ui-bootstrap/custom-theme/ui-bg_glass_75_ffffff_1x400.png' #7

Closed
jsantos opened this Issue Feb 13, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@jsantos
Contributor

jsantos commented Feb 13, 2014

When using the gem sprockets_better_errors gem, the following warning is displaying, mentioning something is missing from one of the library files:

Sprockets::Rails::Helper::DependencyError at /
Asset depends on 'ui-bootstrap/custom-theme/ui-bg_glass_75_ffffff_1x400.png' to generate properly but has not declared the dependency
Please add: `//= depend_on_asset "ui-bootstrap/custom-theme/ui-bg_glass_75_ffffff_1x400.png"` to '/Users/jsantos/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/bundler/gems/jquery-ui-bootstrap-rails-47957c2250ee/vendor/assets/stylesheets/ui-bootstrap/jquery-ui-bootstrap.latest.css.scss'
  (in /Users/jsantos/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.

I'm using the following gems as well:

gem 'jquery-rails'
gem 'jquery-ui-rails'

And on my CSS manifest, application.css:

 *
 *= require_self
 *= require ui-bootstrap/jquery-ui-bootstrap.latest
 *= require_tree .
 */

When I deploy my code to production, after asset precompilation the mentioned file does not show up, as warned by sprockets_better_errors. The icons are missing.

Am I missing something obvious here?

@kristianmandrup

This comment has been minimized.

Show comment
Hide comment
@kristianmandrup

kristianmandrup Feb 13, 2014

Owner

Cool :) The error msg says what you have to do:

Please add: `//= depend_on_asset "ui-bootstrap/custom-theme/ui-bg_glass_75_ffffff_1x400.png"` to '/Users/jsantos/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/bundler/gems/jquery-ui-bootstrap-rails-47957c2250ee/vendor/assets/stylesheets/ui-bootstrap/jquery-ui-bootstrap.latest.css.scss'

Which means that this gem needs to be updated with

//= depend_on_asset "ui-bootstrap/custom-theme/ui-bg_glass_75_ffffff_1x400.png

I guess you should put this in vendor/assets/stylesheets/ui-bootstrap/jquery-ui-bootstrap.latest.css.scss'

I have never seen this depend_on_asset before. I guess it's a new optimization in sprockets?

FortAwesome/font-awesome-sass#13
rails/sprockets-rails#96

Please fork and add this, test and make it work... then make a pull request ;) thanks!

Owner

kristianmandrup commented Feb 13, 2014

Cool :) The error msg says what you have to do:

Please add: `//= depend_on_asset "ui-bootstrap/custom-theme/ui-bg_glass_75_ffffff_1x400.png"` to '/Users/jsantos/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/bundler/gems/jquery-ui-bootstrap-rails-47957c2250ee/vendor/assets/stylesheets/ui-bootstrap/jquery-ui-bootstrap.latest.css.scss'

Which means that this gem needs to be updated with

//= depend_on_asset "ui-bootstrap/custom-theme/ui-bg_glass_75_ffffff_1x400.png

I guess you should put this in vendor/assets/stylesheets/ui-bootstrap/jquery-ui-bootstrap.latest.css.scss'

I have never seen this depend_on_asset before. I guess it's a new optimization in sprockets?

FortAwesome/font-awesome-sass#13
rails/sprockets-rails#96

Please fork and add this, test and make it work... then make a pull request ;) thanks!

@jsantos

This comment has been minimized.

Show comment
Hide comment
@jsantos

jsantos Feb 13, 2014

Contributor

Hi,

Well, I figured these kinds of errors when I started using this gem (funny thing). But usually I just need to include that kind of //= depend_of_asset if I have a js.erb/css.erb which mentions assets imported through ruby helpers... Maybe it's not the only situation!

I'll try it out and will create a pull request for it ;)

Contributor

jsantos commented Feb 13, 2014

Hi,

Well, I figured these kinds of errors when I started using this gem (funny thing). But usually I just need to include that kind of //= depend_of_asset if I have a js.erb/css.erb which mentions assets imported through ruby helpers... Maybe it's not the only situation!

I'll try it out and will create a pull request for it ;)

kristianmandrup added a commit that referenced this issue Feb 13, 2014

Merge pull request #8 from jsantos/depend_on_asset
Added asset dependency statements on stylesheets - issue #7

@jsantos jsantos closed this Feb 13, 2014

@kristianmandrup

This comment has been minimized.

Show comment
Hide comment
@kristianmandrup

kristianmandrup Feb 14, 2014

Owner

Tried pushing to rubygems

$ bundle exec rake release
Committing jquery-ui-bootstrap-rails.gemspec
Pushing master to origin
Generated: jquery-ui-bootstrap-rails.gemspec
jquery-ui-bootstrap-rails.gemspec is valid.
  Successfully built RubyGem
  Name: jquery-ui-bootstrap-rails
  Version: 0.1.1
  File: jquery-ui-bootstrap-rails-0.1.1.gem
Executing "gem push ./pkg/jquery-ui-bootstrap-rails-0.1.1.gem":
gem push ./pkg/jquery-ui-bootstrap-rails-0.1.1.gem
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem.

You are welcome to take over as owner/maintainer if you like ;)

Owner

kristianmandrup commented Feb 14, 2014

Tried pushing to rubygems

$ bundle exec rake release
Committing jquery-ui-bootstrap-rails.gemspec
Pushing master to origin
Generated: jquery-ui-bootstrap-rails.gemspec
jquery-ui-bootstrap-rails.gemspec is valid.
  Successfully built RubyGem
  Name: jquery-ui-bootstrap-rails
  Version: 0.1.1
  File: jquery-ui-bootstrap-rails-0.1.1.gem
Executing "gem push ./pkg/jquery-ui-bootstrap-rails-0.1.1.gem":
gem push ./pkg/jquery-ui-bootstrap-rails-0.1.1.gem
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem.

You are welcome to take over as owner/maintainer if you like ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment