Skip to content
Browse files

milkymist: try -Wmissing-prototypes

The math functions have too many issues to make this viable without
substantially more fixing. Just fix what little else is there.
  • Loading branch information...
1 parent abec542 commit ad116238f2c86c0c8f033ad9548d5bcfff13101d @wpwrak wpwrak committed with sbourdeauducq Dec 12, 2011
Showing with 3 additions and 2 deletions.
  1. +1 −0 software/include.mak
  2. +2 −2 software/libhal/ukb.c
View
1 software/include.mak
@@ -37,6 +37,7 @@ endif
INCLUDES_NOLIBC ?= -nostdinc -I$(MMDIR)/software/include/base
INCLUDES = $(INCLUDES_NOLIBC) -I$(MMDIR)/software/include -I$(MMDIR)/tools
ASFLAGS = $(INCLUDES) -nostdinc
+# later: -Wmissing-prototypes
CFLAGS = -O9 -Wall -Wstrict-prototypes \
-mbarrel-shift-enabled -mmultiply-enabled -mdivide-enabled \
-msign-extend-enabled -fno-builtin -fsigned-char \
View
4 software/libhal/ukb.c
@@ -27,7 +27,7 @@ static char rx_buf[UKB_RINGBUFFER_SIZE_RX];
static volatile unsigned int rx_produce;
static volatile unsigned int rx_consume;
-char ukb_readchar(void)
+static char ukb_readchar(void)
{
char c;
@@ -37,7 +37,7 @@ char ukb_readchar(void)
return c;
}
-int ukb_readchar_nonblock(void)
+static int ukb_readchar_nonblock(void)
{
return (rx_consume != rx_produce);
}

0 comments on commit ad11623

Please sign in to comment.
Something went wrong with that request. Please try again.