Update lib/Buzz/Client/AbstractCurl.php #99

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@lmammino
lmammino commented Dec 8, 2012

Improved curl proper installation/initialization check

Without this check, if you have curl not installed/misconfigured, the RuntimeException is never thrown because everything is stopped by the following error:

Fatal error: Call to undefined function Buzz\Client\curl_init() in .../vendor/kriswallsmith/buzz/lib/Buzz/Client/AbstractCurl.php on line 26
@lmammino lmammino Update lib/Buzz/Client/AbstractCurl.php
Improved curl proper installation/initialization check
b3f8359
@mauris
mauris commented Jan 14, 2013

+1 merge please.

@kriswallsmith
Owner

I would rather not pollute runtime with dependency checks…

@lmammino

@kriswallsmith, I may agree with you but IMHO if you want to do so you should remove the whole check (instead having a partially functional check)

@kriswallsmith
Owner

According to the PHP manual curl_init() will return "FALSE on errors." This is not a check to see if the extension is installed.

@lmammino

Ok, now I truly got your point of view. So you can consider the issue closed and reject the pull request.

@kriswallsmith
Owner

Thanks @lmammino!

@lmammino

No need to say thanks @kriswallsmith !
Me and the whole PHP community should say thanks to you for giving us Assetic, Buzz and Spork 👍

Keep coding with such brilliance, man!

@akaramires

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment