Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added the ability to set the paths searched by @import in the less filter #218

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@ghost

ghost commented Apr 10, 2012

This patch allows the the user to specify the import paths searched by less.

It makes using libraries of less files such as twitter bootstrap much easier as the paths don't need to be relative to the included file any longer.

@ghost

ghost commented Apr 19, 2012

Any news on this PR?

Owner

kriswallsmith commented May 9, 2012

Hi @web-dev — Can you tell me what your use-case is for this change?

@ghost

ghost commented May 10, 2012

Hi @kriswallsmith, My use case is simple - to include files from twitter bootstrap in circumstances where they can't be symbolically linked.

Specifically I'm compiling LESS scripts and with parameters that the user can configure (which are output from twig view templates) using a temporary folder. As such less has no access to the twitter bootstrap files as it compiles from the temporary directory and doesn't get the advantage of the standard filter behaviour where it adds a path for the current script.

It is also my intention to add a configuration parameter that can be used to set alternate paths in the bundle configuration for use when rendering inside templates with {% stylesheets %}

@ghost

ghost commented Jul 4, 2012

Bump... I've got code in production that relies on this change now, and I'm using my fork - is there anything that is holding up this PR?

Collaborator

schmittjoh commented Jul 20, 2012

Looks good, could you add a small test to LessFilterTest?

Collaborator

stof commented Aug 28, 2012

@web-dev ping

@ghost ghost closed this Aug 29, 2012

@ghost

ghost commented Aug 29, 2012

PR Re-submitted with my new github account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment