Permalink
Switch branches/tags
Commits on Dec 30, 2015
  1. Resizing the grid in response to resize events, when the grid is not

    kriszyp committed Aug 28, 2015
    visible, is not helpful, and it only smashes the header.
Commits on Dec 17, 2015
  1. Fix #1157: Tree: avoid duplicate rendering in _configureTreeColumn

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Dec 17, 2015
    This addresses cases where the same column definition object is passed
    to one of the structure-related setters, as is the case when using
    ColumnReorder.
    
    Thanks to @dmartinzar for the bug report and original example + fix, and
    @maier49 for the initial unit test.
    
    Resolves #1185.
Commits on Dec 11, 2015
  1. Fix stores test to avoid infinite recursion

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Dec 11, 2015
  2. Fix #1156: _StoreMixin: Call _processScroll after adjustRowIndices

    dmartinzar authored and Kenneth G. Franqueiro committed Sep 29, 2015
    This resolves an off-by-one error which can cause rows to appear
    in the incorrect order after updates, due to _processScroll being
    called after a row is removed but before indices are recalculated.
  3. Fix #1069: Tree: Continue to listen for transitionend events

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Dec 11, 2015
    The container only gets created once, so we need to listen for more than the
    first transitionend event, in order to remove the fixed height which could
    interfere with inner parent expansion.
    
    Additionally, the immediate call to `_onTreeTransitionEnd` is unnecessary,
    since the no-transition path skips height adjustment and already handles
    updating the display property elsewhere.
    
    Thanks @jbomer, @bogool, and @kriszyp for poking at this and helping to
    arrive at the solution.
  4. Document _StoreMixin#refreshCell

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Dec 11, 2015
  5. Add _StoreMixin#refreshCell and unit tests

    Mangala SSS Khalsa Kenneth G. Franqueiro
    Mangala SSS Khalsa authored and Kenneth G. Franqueiro committed Sep 26, 2015
  6. Grid: Refactor cell creation methods to be directly callable/extensible

    Mangala SSS Khalsa Kenneth G. Franqueiro
    Mangala SSS Khalsa authored and Kenneth G. Franqueiro committed Sep 26, 2015
    This refactors logic from the inner function in `renderRow` into
    `_createBodyRowCell`, and from the inner funtion in `renderHeader` into
    `_createHeaderRowCell`.
  7. Fix #1192: Prevent notifications from causing a request for page 0

    maier49 authored and Kenneth G. Franqueiro committed Oct 23, 2015
Commits on Oct 30, 2015
  1. Fix #1147: ColumnResizer: Protect header cells from clicks on resize

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Oct 1, 2015
  2. Fix #1196: Improve documentation for save method

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Oct 30, 2015
  3. Fix #1066: Document 'colSpan' and 'rowSpan' column definition proper…

    Mangala SSS Khalsa Kenneth G. Franqueiro
    Mangala SSS Khalsa authored and Kenneth G. Franqueiro committed Oct 23, 2015
    …ties
Commits on Oct 1, 2015
  1. Add migration documentation for the `sort` property and fix a broken …

    mwistrand authored and Kenneth G. Franqueiro committed Sep 30, 2015
    …URL.
    
    
    Fixes #1186.
    Resolves #1189.
Commits on Sep 25, 2015
  1. DijitRegistry: Add placeAt (delegating to _WidgetBase's)

    kfranqueiro authored and Kenneth G. Franqueiro committed Jun 5, 2015
    Includes unit tests.
    
    Resolves #1135.
  2. DnD: Improve reliability for collection errors

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Sep 25, 2015
    * Add manual test page for testing errors on collections
    * Only remove moved item if put/copy is successful first
    * Track errors and report via dgrid-error event
    
    As @mercmobily states in the comments in his initial proposal,
    this avoids losing data due to items being removed before the
    write to the destination was successful, reducing the worst-case
    scenario to a move operation behaving like a copy instead
    (if the destination's add succeeds but the source's remove fails).
    
    Resolves #806.
    Resolves #949.
  3. Fix createIndex script for running on Windows

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Sep 25, 2015
Commits on Sep 23, 2015
  1. _StoreMixin#save: Add tests for promise resolution; fix an edge case

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Sep 23, 2015
    Ensure save always resolves to an object, even if nothing was saved.
    
    Also fixes the test store in test/Editor.html, which was dropping the
    original promise returned from put.
    
    Refs #655.
  2. _StoreMixin#save: Expose original put call results

    Jochen Schäfer Kenneth G. Franqueiro
    Jochen Schäfer authored and Kenneth G. Franqueiro committed Sep 23, 2015
    Resolves #655.
Commits on Sep 18, 2015
  1. Fix #1179: ColumnSet: Avoid wheel/touch event errors in empty viewport

    Mangala SSS Khalsa Kenneth G. Franqueiro
    Mangala SSS Khalsa authored and Kenneth G. Franqueiro committed Sep 12, 2015
  2. Update dgrid tests for Intern 3

    csnover authored and kfranqueiro committed May 28, 2015
Commits on Sep 17, 2015
  1. Fix #1130: Avoid invoking empty sort on child levels

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Sep 17, 2015
    This makes Tree's logic consistent with _StoreMixin's, wherein
    collection.sort is not called whatsoever if sort is an empty array.
    
    This ultimately points to an issue which should also likely be
    fixed in dstore.
    
    Thanks @msssk for narrowing down this issue.
Commits on Jul 1, 2015
  1. ColumnSet: Fix horizontal scrollbar regression on IE8

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Jul 1, 2015
    Also remove a space that was added to a query selector in
    _onColumnSetScroll, which inexplicably causes acme to crash IE8
Commits on Jun 15, 2015
  1. Fix invisible focus rectangles on Firefox

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Jun 15, 2015
    This re-applies a selector initially dropped from 0.4,
    while avoiding a * selector.  It resolves an issue where clicking on
    a row/cell does not show the focus rectangle, though using the tab key
    still works.
Commits on Jun 12, 2015
  1. Fix #1142: Expand Editor docs on when dgrid-datachange event fires

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Jun 12, 2015
  2. Remove util/misc#contains

    jdonaghue authored and Kenneth G. Franqueiro committed Jun 10, 2015
    The `else` code path of this function was no longer used by any supported
    browsers, and the compareDocumentPosition call was actually written backwards
    (essentially proving that it was never being used, since we never noticed).
    
    Also removes a bit of leftover IE < 8 code in CompoundColumns.
Commits on Jun 11, 2015
  1. Update docs to reflect #1144

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Jun 11, 2015
  2. Fixes for stores unit test suite

    kfranqueiro committed Apr 17, 2015
    * Fix bugs in errorStores module for stores unit test suite
      which surfaced after removing superfluous when calls
    * Avoid spurious errors after tests resolve
    * Fix errors in store tests with dstore 1.1
    * Ensure dgrid.css is loaded for OnDemandList tests
    
    The tests for releaseRange logic in dgrid were making use of an
    internal property on stores which is no longer present in dstore 1.1;
    this update replaces that with more appropriate tests based on
    observed behavior within the grid itself.
Commits on Jun 9, 2015
  1. Update Editor.js

    wacekgocki authored and Kenneth G. Franqueiro committed Apr 4, 2015
    This fixes a little typo in Editor.js, which causes the
    "TypeError: node is null" error, when you want to use textarea control
    as an editor in grid.
  2. ColumnSet: Aspect Tree#expand to recompute scrollLeft

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Jun 9, 2015
    This resolves an issue where skew occurs (until you scroll again) if you
    expand a row, collapse it, scroll a column set, then re-expand it.
    
    Thanks to @jdonaghue for help with porting and debugging this.
  3. Fix css loading for unit tests

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Jun 9, 2015
Commits on Jun 8, 2015
  1. Add mention of Trackable to 0.4 migration guide

    Kenneth G. Franqueiro
    Kenneth G. Franqueiro committed Jun 8, 2015
Commits on Jun 5, 2015
  1. Add documentation indicating that Grid and List do not support stores

    jdonaghue authored and Kenneth G. Franqueiro committed Jun 4, 2015