IE8 strangely returns elements without the passed id while using .all…

…, checking if it exists before checking its value.
kriszyp · Feb 23, 2011 · 0ca58ca · 0ca58ca
1 parent 233dab9
commit 0ca58ca
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/Source/Slick.Finder.js b/Source/Slick.Finder.js
@@ -618,9 +618,12 @@ var combinators = {
 					children = node.all[id];
 					if (!children) return;
 					if (!children[0]) children = [children];
-					for (i = 0; item = children[i++];) if (item.getAttributeNode('id').nodeValue == id){
-						this.push(item, tag, null, classes, attributes, pseudos);
-						break;
+					for (i = 0; item = children[i++];){
+						var idNode = item.getAttributeNode('id');
+						if (idNode && idNode.nodeValue == id){
+							this.push(item, tag, null, classes, attributes, pseudos);
+							break;
+						}
 					} 
 					return;
 				}