Generify functions and userdata types #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the rationale is that typically functions receive a well-defined list of argument types and require either an ArgumentIterator to peel out the values or directly cast their parameters to the specific type. Not only is that error prone, it also required duplicate work all over the place. By allowing to specify the argument types no such casting is required for the common case as the simple type parameter allows IDEs to properly create method signatures. The same applies to userdata, which is very often used to expose Java classes into Lua. In those cases the types are well known to the programmer and no helper fields, type casts or other checks are required, because the user data is already encapsulated. Thus the boilerplate required is reduced and the user code becomes clearer.
use them if the types of the parameters aren't known, or you don't want to use generics this is syntactic sugar to avoid having to spell out the type parameters every time migrate internal usage to untyped abstract functions where applicable
kroepke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rationale is that typically functions receive a well-defined list of argument types
and require either an ArgumentIterator to peel out the values or directly cast their
parameters to the specific type.
Not only is that error prone, it also required duplicate work all over the place.
By allowing to specify the argument types no such casting is required for the common case
as the simple type parameter allows IDEs to properly create method signatures.
The same applies to userdata, which is very often used to expose Java classes into Lua.
In those cases the types are well known to the programmer and no helper fields, type casts or
other checks are required, because the user data is already encapsulated.
Thus the boilerplate required is reduced and the user code becomes clearer.