New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinker updates #46

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
2 participants
@gcabbage
Contributor

gcabbage commented Jun 16, 2017

This PR contains code I started writing for Suggestion: Tinker recipes from ROMs. As most of changes could be useful even without the ROM suggestion I’m opening it for review:

@gmoromisato gmoromisato merged commit 21077c8 into kronosaur:master Jun 27, 2017

@gmoromisato

This comment has been minimized.

Show comment
Hide comment
@gmoromisato

gmoromisato Jun 27, 2017

Member

Looks great, and I totally approve of the direction you're going.

Do we need to enhance the component crafting code to support some of the Tinker recipe features (like fixed prices, etc.)?

Member

gmoromisato commented Jun 27, 2017

Looks great, and I totally approve of the direction you're going.

Do we need to enhance the component crafting code to support some of the Tinker recipe features (like fixed prices, etc.)?

@gcabbage

This comment has been minimized.

Show comment
Hide comment
@gcabbage

gcabbage Jun 27, 2017

Contributor

Do we need to enhance the component crafting code to support some of the Tinker recipe features (like fixed prices, etc.)?

Yes, we'll probably want some of the Tinker features ported to the new system.

I was also considering extending the Tinker recipe system to let it 'wrap' crafting recipes so you could allow enhancements / fixed prices, or ways of controling when recipies are available etc.
e.g. a tinker recipe with:
{ item:&itOrthoSteel; enhancement:"+regen" components: ( 'craftingComponents { item:&itDuralloyOre; count:4 }) }
could allow you to craft an enhancemt segment of armor using the default components for that armor + dualloy ore

EDIT - this would also allow you to have variations of the same recipe from multiple sources.
e.g.
Corporate might craft the recipe at 0 markup for players with high rank.
Tinkers have the same recipe for everyone, but at high cost.

Contributor

gcabbage commented Jun 27, 2017

Do we need to enhance the component crafting code to support some of the Tinker recipe features (like fixed prices, etc.)?

Yes, we'll probably want some of the Tinker features ported to the new system.

I was also considering extending the Tinker recipe system to let it 'wrap' crafting recipes so you could allow enhancements / fixed prices, or ways of controling when recipies are available etc.
e.g. a tinker recipe with:
{ item:&itOrthoSteel; enhancement:"+regen" components: ( 'craftingComponents { item:&itDuralloyOre; count:4 }) }
could allow you to craft an enhancemt segment of armor using the default components for that armor + dualloy ore

EDIT - this would also allow you to have variations of the same recipe from multiple sources.
e.g.
Corporate might craft the recipe at 0 markup for players with high rank.
Tinkers have the same recipe for everyone, but at high cost.

@gcabbage gcabbage deleted the gcabbage:tinkers branch Jun 27, 2017

@gmoromisato

This comment has been minimized.

Show comment
Hide comment
@gmoromisato

gmoromisato Jul 1, 2017

Member

Could you do me a favor a write a quick reference guide in Ministry for how to specify Tinker recipes? I think Shrike would appreciate it!

Member

gmoromisato commented Jul 1, 2017

Could you do me a favor a write a quick reference guide in Ministry for how to specify Tinker recipes? I think Shrike would appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment