stable1-proposed #140
Merged
stable1-proposed #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libknet cannot guarantee that the dst_host_filter is sane nor that it cannot be exploited to return garbage to knet. there is an infinitesimal possibility that, if the plugin returns total crap, knet could crash by trying to access out-of-bound memory. Prevent that by adding specific checks both in TX/RX. Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
- make val_level internal api call optional - keep lzo2 val_level around due to the specific nature of compress_level values - add internal compress_lib_test to do a round-robin (compress/decompress) check with provided values - drop unnecessary val_level checks around - update internal compress API include file - adjust api_knet_handle_compress test to use a known bad value for zlib validation Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
fabbione
changed the title
Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>
Based on Fabio's original patch. Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com> Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com> Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Ferenc Wágner <wferi@debian.org>
Signed-off-by: Ferenc Wágner <wferi@debian.org>
knet-ci-bot
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libknet cannot guarantee that the dst_host_filter is sane nor that it cannot
be exploited to return garbage to knet.
there is an infinitesimal possibility that, if the plugin returns total crap,
knet could crash by trying to access out-of-bound memory.
Prevent that by adding specific checks both in TX/RX.
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com