Skip to content

Conversation

@robobario
Copy link
Member

@robobario robobario commented Jan 12, 2024

Type of change

  • Enhancement / new feature

Description

Why:
In Kafka 3.7 the MetaProperties has changed package, so the extension fails with an exception at Runtime when it tries to invoke buildMetadataProperties if we have the 3.7 kafka server on the classpath.

This change will be required when we upgrade the extension to compile against 3.7 to support backwards compatibility with Kafka 3.6

Additional Context

Strimzi are preparing to use Kafka 3.7 and this breaks their tests at runtime as we can no longer start up embedded brokers.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@robobario robobario force-pushed the kafka-37-backwards-compat branch from eb7ec9c to cfaafdb Compare January 12, 2024 00:23
@robobario robobario force-pushed the kafka-37-backwards-compat branch 2 times, most recently from 7681985 to 9202bdb Compare January 12, 2024 00:35
Copy link
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nasty but I'm not sure what else to suggest.

Thanks @robobario

@robobario
Copy link
Member Author

Have tested against the strimzi 3.7 PR branch by running the topic-operator tests against a locally built extension snapshot.

[INFO] Results:
[INFO] 
[WARNING] Tests run: 134, Failures: 0, Errors: 0, Skipped: 1
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  50.779 s
[INFO] Finished at: 2024-01-12T13:39:54+13:00
[INFO] ------------------------------------------------------------------------

@robobario robobario force-pushed the kafka-37-backwards-compat branch from 9202bdb to c25b467 Compare January 12, 2024 00:49
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Why:
In Kafka 3.7 the MetaProperties has changed package, so the extension
fails with an exception at Runtime when it tries to invoke buildMetadataProperties
if we have the 3.7 kafka server on the classpath.

This change will be required when we upgrade the extension to compile against 3.7
to support backwards compatibility with Kafka 3.6
@robobario robobario merged commit 9facefa into kroxylicious:main Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants