Fixed issue: cleanup() function not call in onerror handler. #40

wants to merge 1 commit into


None yet
2 participants

Calling error() function raise exception and prevent cleanup() calling.


jnewman commented Feb 28, 2014

This breaks a test. I'll take a look at it in the future, but I won't merge until the tests pass...

jnewman self-assigned this Feb 28, 2014

jnewman added the lint label Feb 28, 2014


jnewman commented Apr 8, 2014

What was the negative side-effect of this? (Figuring out if this needs to be fixed.)

@jnewman error() function called before cleanup() and this means that cleanup never been called because error will stop program execution.


jnewman commented Apr 10, 2014

Looked through this. We'll need to move done() out of cleanup to make it pass on the CI. (What you have will fire the success handler when the script load failed.)

jnewman closed this in 0cf9df9 Apr 24, 2014

sethyates locked and limited conversation to collaborators Apr 9, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.