Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes #37

Open
wants to merge 8 commits into
base: xft-port
from

Conversation

Projects
None yet
7 participants
@mstarodub
Copy link

commented Feb 23, 2019

Correctly escaped % symbols

baskerville and others added some commits Nov 16, 2016

Fix {top,bottom}_end_x strut value
The maximum x coordinate of a pixel inside the rectangle (x, y, w, h) is x+w-1.

The specs (https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317564416)
provides an example that corroborates the fact that the range is inclusive: bottom_end_x is 2303.
This value can be interpreted as 1280+1024-1.
Merge pull request LemonBoy#193 from baskerville/fix-end-x
Fix {top,bottom}_end_x strut value
@krypt-n

This comment has been minimized.

Copy link
Owner

commented Mar 15, 2019

One would think that I would get an email notification if someone opens a PR on a repo I own. Anyway, I'm not really a user of lemonbar anymore. Have you tested these changes with a reasonably complex configuration?

@mstarodub

This comment has been minimized.

Copy link
Author

commented Mar 15, 2019

It works well with my configuration, although it's far from complex.
What do you use instead?

@expectocode

This comment has been minimized.

Copy link

commented Apr 23, 2019

I've put up a repo at https://github.com/expectocode/bar that has these updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.