Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why? #5

Closed
schwa opened this issue Aug 26, 2014 · 6 comments
Closed

Why? #5

schwa opened this issue Aug 26, 2014 · 6 comments

Comments

@schwa
Copy link

@schwa schwa commented Aug 26, 2014

Why not just use CommonCrypto from Swift?

What's the reasoning behind creating this project?

Thanks!

@krzyzanowskim
Copy link
Owner

@krzyzanowskim krzyzanowskim commented Aug 26, 2014

Because I can.

At first I played with OpenSSL and CommonCrypto, then I moved to pure Swift implementation, partly for fun, partly because I'm about to implement things that are not available in CommonCrypto.

I'm touched that you compared this not to OpenSSL ;)
Cheers.

@fbartho
Copy link

@fbartho fbartho commented Aug 26, 2014

👍 Cool. "Because I can" is a great answer. :) It might be worth writing a section in the Readme addressing/expanding on the "why" of this library so people who don't see this issue also get that context :)

@hpique
Copy link

@hpique hpique commented Oct 15, 2014

@schwa @krzyzanowskim Also, because adding CommonCrypto to a Swift framework (not app) is broken.

See http://stackoverflow.com/questions/25248598/importing-commoncrypto-in-a-swift-framework.

@eneko
Copy link
Contributor

@eneko eneko commented Dec 18, 2014

Thanks for putting this library together. Love #pureswift. Keep the good work!

@smil2k
Copy link

@smil2k smil2k commented Jan 30, 2016

Very much appreciated! Using "native" libraries invalidates the security benefits of a safe lingo...

@onmyway133
Copy link

@onmyway133 onmyway133 commented May 10, 2016

@hpique I think it works now https://github.com/onmyway133/CommonCrypto.swift
But Cryptoswift is so awesome. @krzyzanowskim like in https://github.com/krzyzanowskim/CryptoSwift/blob/master/Sources/CryptoSwift/MD5.swift if the test fails, how do you know where to fix? All seem magic numbers to me

Repository owner locked and limited conversation to collaborators Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants