Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix DEPRECATION warning from RSpec. #93

Merged
merged 1 commit into from Oct 23, 2013

Conversation

Projects
None yet
2 participants
Contributor

tadd commented Oct 19, 2013

I began to use parslet, it looks really cool.
Unfortunately, it doesn't pass spec well. I got no failure but some warnings with running rspec command:

Run options: exclude {:ruby=>#<Proc:./spec/spec_helper.rb:13>}
...........................................DEPRECATION: `expect { }.not_to raise_error(SpecificErrorClass)` is deprecated. Use `expect { }.not_to raise_error` (with no args) instead. Called from /home/tadashi/git/parslet/spec/acceptance/regression_spec.rb:87:in `block (4 levels) in <top (required)>'.
.......................................................................................................................................................................DEPRECATION: `expect { }.not_to raise_error(SpecificErrorClass)` is deprecated. Use `expect { }.not_to raise_error` (with no args) instead. Called from /home/tadashi/git/parslet/spec/parslet/convenience_spec.rb:21:in `block (4 levels) in <top (required)>'.
.DEPRECATION: `expect { }.not_to raise_error(SpecificErrorClass)` is deprecated. Use `expect { }.not_to raise_error` (with no args) instead. Called from /home/tadashi/git/parslet/spec/parslet/convenience_spec.rb:24:in `block (4 levels) in <top (required)>'.
...................................................................................................................................................................................................

Finished in 5.08 seconds
406 examples, 0 failures

I agree with the warnings because it seems that raising nothing is correct spec, so I removed class specification.

My rspec version is:

$ rspec --version
2.14.6

kschiess added a commit that referenced this pull request Oct 23, 2013

@kschiess kschiess merged commit b666a8a into kschiess:master Oct 23, 2013

Owner

kschiess commented Oct 23, 2013

Thanks!

Contributor

tadd commented Oct 23, 2013

Oh, you're welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment