Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batcher module. #847

Merged
merged 36 commits into from Jun 22, 2020
Merged

Add batcher module. #847

merged 36 commits into from Jun 22, 2020

Conversation

zhangrongguo
Copy link
Contributor

@zhangrongguo zhangrongguo commented May 28, 2020

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @zhangrongguo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhangrongguo
Copy link
Contributor Author

/assign @yuzisun

@yuzisun
Copy link
Member

yuzisun commented May 29, 2020

/ok-to-test

@zhangrongguo
Copy link
Contributor Author

/retest

pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
pkg/batcher/controllers/default.go Outdated Show resolved Hide resolved
@yuzisun
Copy link
Member

yuzisun commented May 31, 2020

@zhangrongguo Glad to see the your progress on batching! I left some comments and questions.

I also did a test with vegeta seems some requests are returning 503 and tail latency is a bit high, any idea why ?

Requests      [total, rate, throughput]  30000, 500.00, 472.28
Duration      [total, attack, wait]      1m0.05819466s, 59.999824032s, 58.370628ms
Latencies     [mean, 50, 95, 99, max]    3.676433197s, 12.482479ms, 23.264452521s, 25.398686534s, 29.171002974s
Bytes In      [total, mean]              2740601, 91.35
Bytes Out     [total, mean]              2460000, 82.00
Success       [ratio]                    94.55%
Status Codes  [code:count]               200:28364  503:1636  
Error Set:
503 Service Unavailable

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

pkg/apis/serving/v1alpha2/inferenceservice_types.go Outdated Show resolved Hide resolved
cmd/batcher/main.go Outdated Show resolved Hide resolved
@zhangrongguo
Copy link
Contributor Author

/retest

@yuzisun
Copy link
Member

yuzisun commented Jun 18, 2020

Good with this for the first cut, suggested follow up changes in #890 and combining logger/batcher will be in proposal #802.

@ellistarn @cliveseldon do you have any comments for batcher?

cmd/batcher/main.go Outdated Show resolved Hide resolved
pkg/batcher/controllers/main_controller.go Outdated Show resolved Hide resolved
pkg/batcher/routers/router.go Outdated Show resolved Hide resolved
pkg/batcher/server.go Outdated Show resolved Hide resolved
pkg/batcher/server_test.go Outdated Show resolved Hide resolved
pkg/webhook/admission/pod/batcher_injector.go Outdated Show resolved Hide resolved
pkg/webhook/admission/pod/batcher_injector_test.go Outdated Show resolved Hide resolved
test/e2e/batcher/test_batcher.py Outdated Show resolved Hide resolved
test/scripts/build-batcher.sh Outdated Show resolved Hide resolved
@ellistarn
Copy link
Collaborator

Mostly LGTM. A couple interface nits.

@zhangrongguo
Copy link
Contributor Author

/retest

1 similar comment
@zhangrongguo
Copy link
Contributor Author

/retest

@yuzisun
Copy link
Member

yuzisun commented Jun 20, 2020

/retest

@yuzisun
Copy link
Member

yuzisun commented Jun 22, 2020

Awesome contribution @zhangrongguo! Excited to see this great feature and thanks for addressing all the comments!
/lgtm

@yuzisun
Copy link
Member

yuzisun commented Jun 22, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87b45e0 into kserve:master Jun 22, 2020
2 of 3 checks passed
ellistarn pushed a commit to ellistarn/kfserving that referenced this pull request Jul 28, 2020
* Add batcher module.

* Add batcher module.

* Add batcher e2e test timeout.

* Add batcher e2e test timeout.

* Some changes according to PR comments.

* Enlarge batcher resource.

* Change image name of batcher for CI.

* Change batcher resource.

* Changes according to comments of PR.

* Add vendor/github.com/astaxie/beego vendor/github.com/satori/go.uuid vendor/github.com/shiena/ansicolor.

* Add release/triggers/latest/batcher.yaml release/triggers/tagged/batcher.yaml.

* Change mode of test/scripts/build-batcher.sh.

* Change mode of test/scripts/build-batcher.sh.

* Change mode of test/scripts/build-batcher.sh.

* Fix import time issue and change the resource of batcher.

* Add dependencies.

* Add dependencies.

* Fix pkg/webhook/admission/pod/batcher_injector_test.go issue.

* delete vendor.

* Change batcher.Dockerfile.

* Change test/scripts/build-batcher.sh prow_config.yaml.

* Change test/scripts/build-batcher.sh prow_config.yaml.

* Change batcher README.md.

* Change batcher README.md.

* Change batcher container name to batcher.

* Change batcher README.md.

* Change batcher README.md.

* Change license.

* Change the type of maxBatchSize, maxLatency, timeout to int type.

* Fix addBatcherAnnotations issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants