Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapcraft yaml #267

Merged
merged 3 commits into from Mar 9, 2020
Merged

Add snapcraft yaml #267

merged 3 commits into from Mar 9, 2020

Conversation

@LyzardKing
Copy link
Contributor

LyzardKing commented Mar 9, 2020

This PR adds a snap yaml file that generates the snap package.
It's been briefly tested on my system, but might need more testing.

@DamirPorobic DamirPorobic self-requested a review Mar 9, 2020
@DamirPorobic

This comment has been minimized.

Copy link
Member

DamirPorobic commented Mar 9, 2020

Awesome, thanks for providing this PR. This can be used to locally build the snap? The snap needs then to be pushed manually to snapcraft, right?

@LyzardKing

This comment has been minimized.

Copy link
Contributor Author

LyzardKing commented Mar 9, 2020

This can be used to build locally,
but you can create an account on build.snapcraft.io, link it to your github and add the ksnip repo.
Then It'll automatically build on every commit to master.

@DamirPorobic DamirPorobic added this to To do in v1.7.0 via automation Mar 9, 2020
@DamirPorobic

This comment has been minimized.

Copy link
Member

DamirPorobic commented Mar 9, 2020

Is it possible to differentiate between tagged and untagged build? Tagged build are finished releases.

Anyways, thanks for providing this, I'll test the build take care of the integration with snapcraft.

@DamirPorobic DamirPorobic merged commit 9327f43 into ksnip:master Mar 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v1.7.0 automation moved this from To do to Done Mar 9, 2020
@DamirPorobic

This comment has been minimized.

Copy link
Member

DamirPorobic commented Mar 9, 2020

Implements #147

@LyzardKing

This comment has been minimized.

Copy link
Contributor Author

LyzardKing commented Mar 9, 2020

If you add it on build.snapcraft.io it'll upload the builds from master to the "-edge" channel.
Then you can manually set that to "-stable" when you make a proper release.

@DamirPorobic

This comment has been minimized.

Copy link
Member

DamirPorobic commented Mar 9, 2020

Awesome, thanks for clarifying :)

@DamirPorobic

This comment has been minimized.

Copy link
Member

DamirPorobic commented Mar 22, 2020

@LyzardKing I had finally time to build the snap locally and via build.snapcraft.io though with both I get following error:
/snap/ksnip/x1/bin/ksnip: error while loading shared libraries: libQt5Network.so.5: cannot open shared object file: No such file or directory

I can't see any Qt dependencies that you have defined in the yaml, where do I need to set it?

Also, just for your information, I was able to build the snap with the yaml that you have provided but uploading to snapcraft.io failed with a strange messages. After some investigation I figured out that the description section in the yaml was missing, which seems to be mandatory, after adding it, I was able to upload it.

@LyzardKing

This comment has been minimized.

Copy link
Contributor Author

LyzardKing commented Mar 22, 2020

You're right.. I completely forgot to mention this!
Since I added the kde content snap to be able to run ksnip you first need to run:
snap connect ksnip:kde-frameworks-5-plug kde-frameworks-5-core18:kde-frameworks-5-core18-slot

Regarding the description, I had omitted it thinking it would be read form the appdata xml

@LyzardKing

This comment has been minimized.

Copy link
Contributor Author

LyzardKing commented Mar 22, 2020

@DamirPorobic You can then ask for it to be autoconnected on the snapcraft forum!

@DamirPorobic

This comment has been minimized.

Copy link
Member

DamirPorobic commented Mar 22, 2020

@LyzardKing thanks again for your feedback here, it's very helpful. Regarding the description, you're probably right, after I wrote the post above I've noticed a message telling me that there is a description in the xml will be overwritten by the one from the yaml. Probably the one from the xml has a wrong format, it has htmls tags. Will investigate that later on.

Regarding the autoconnect, can I ask right away to be autoconnected or does something need to happen before we get that autoconnect?

@DamirPorobic

This comment has been minimized.

Copy link
Member

DamirPorobic commented Mar 22, 2020

I need to open a topic here https://forum.snapcraft.io/c/store-requests and ask to connect ksnip to kde-frameworks-5-core18, right?

@DamirPorobic DamirPorobic mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.7.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.