New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow object literal params #218

Closed
hausdorff opened this Issue Dec 12, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@hausdorff
Contributor

hausdorff commented Dec 12, 2017

Right now, if a param is an object, it will cause the rewriter to break in some cases, since it doesn't know how to write objects back.

When go-jsonnet gets an AST writer, we should use it to rewrite the params file, which will resolve this issue "for free."

@hausdorff hausdorff added this to the 0.8 milestone Dec 12, 2017

@hausdorff

This comment has been minimized.

Contributor

hausdorff commented Jan 12, 2018

We are getting this feedback relatively frequently, e.g. here:

how do you deal with large number of params? e.g. if you I to set resources (limit + requests) that's 4 additional params. Use object? But then I cannot use that with ks param set, right? Cause now it seems that I'll have a deployment function with 15+ function args

@jessicayuen

This comment has been minimized.

Contributor

jessicayuen commented Jan 12, 2018

Agree. It will be important for go-jsonnet to get an AST writer. It's becoming unmaintainable to be manipulating the jsonnet text directly in the params file.

@bryanl bryanl removed this from the 0.9.0 milestone Feb 1, 2018

@bryanl

This comment has been minimized.

Member

bryanl commented Mar 22, 2018

Ksonnet lib has an AST printer which can handle objects.

@bryanl bryanl closed this Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment