New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a new version of the object when retrying on conflict #787

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
3 participants
@csmarchbanks
Contributor

csmarchbanks commented Jul 20, 2018

It is necessary to update the resource version if retrying an update due to a conflict. Otherwise, the code retries with the same resource version and will get another 409 back from Kubernetes.

Fixes #650

Signed-off-by: Chris Marchbanks csmarchbanks@gmail.com

Get a new version of the object when retrying on conflict
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
@coveralls

This comment has been minimized.

coveralls commented Jul 20, 2018

Pull Request Test Coverage Report for Build 1235

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 71.202%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cluster/apply.go 8 10 80.0%
Totals Coverage Status
Change from base Build 1229: 0.005%
Covered Lines: 11947
Relevant Lines: 16779

💛 - Coveralls
@bryanl

bryanl approved these changes Jul 25, 2018

@bryanl bryanl merged commit 4b260d7 into ksonnet:master Jul 25, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 71.202%
Details
signed-off-by Commit has Signed-off-by
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment