Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mainstream modules #7

Closed
wants to merge 5 commits into from
Closed

Use mainstream modules #7

wants to merge 5 commits into from

Conversation

CGarces
Copy link

@CGarces CGarces commented Oct 30, 2016

This PR disable some modules from kernel to use the mainstream code at packages/linux-drivers/

It allow to maintain the code up to date and sync with LibreElec repository.

I have send this PR over libreelec-7.0 with the last changes from tags, but I can rebase the PR if needed.

You can obtain a similar PR using this cherry-pick

git cherry-pick c637a0200a5ac6a19a79adc112ab831caea91f86 c80df2f000d0b735e9040414a87d53a41d5eb101 23037b828804fa47d2e7d29c4f60951c6329a14e 6b94a15ae933ab34eafb2ad9e4f196c7f2b69d9a a3dca5031b21f4a12bd303e4cb0517ef030b9282
And the additional changes from 005677ff7492ca0aa2f56d9b547d8de02c203e6a

I have compiled and tested on my S905 device unfortunately has a rtl8189es so I can't test the modules by myself.
If you think that is PR is useful, I can continue the work creating a module for other drivers like rtl8189es, the one used by my android device.

@CGarces CGarces changed the title Mainstream modules Use mainstream modules Oct 30, 2016
@kszaq
Copy link
Owner

kszaq commented Oct 30, 2016

Thank your the PR. Can you rebase this on my libreelec-7.0 branch? Or you can wait for me to push the changes from development tags to this branch. I do not want to use all commits from tags as I sometimes change them (fixups etc.) before pushing into release.

I'm also not sure whether we want to use 8188EU driver from packages as it was reported to not work well with built-in chips.

@CGarces
Copy link
Author

CGarces commented Oct 30, 2016

Done, only two drivers changed RTL8192EU and RTL8812AU.

You have any device with 8188EU to reproduce the error?
Are you interested in a new module for rtl8189es?

Just FYI RTL8188EU was removed from OpenELEC I can't find more information.

@CGarces
Copy link
Author

CGarces commented Oct 31, 2016

Added RTL8189ES as package. Tested on my S905X device.
The source code has been fetched from the kernel.

@kszaq
Copy link
Owner

kszaq commented Oct 31, 2016

Thank you! This will certainly be useful when mainstreaming S805 and S905 projects. 👍

@CGarces
Copy link
Author

CGarces commented Oct 31, 2016

Added 3 new packages
RTL8189FS, RTL8723BS and RTL8822BU
I don't have the proper hardware to test it, but the code comes from the kernel, so must work.
I haven't added it to the options file due lack of testing

@kszaq
Copy link
Owner

kszaq commented Nov 3, 2016

@CGarces Thank you a lot for your input. I think at this point I will cherry-pick your commits to use upstream drivers if that's OK? For Amlogic-specific drivers there are 2 things I would like to change:

@CGarces
Copy link
Author

CGarces commented Nov 3, 2016

No problem, if you cherry-pick the commits I will remove it from the PR.

If you think that use RTLxxxxxx-aml is better, it's ok for me,

Drivers from https://github.com/CGarces/RTL* are from your kernel code so you have a 99% possibilities to success. We can use it as backup plan if mmallow_hardware_wifi_realtek_drivers_* not works.

I'll do it ASAP.

@kszaq
Copy link
Owner

kszaq commented Nov 3, 2016

No rush. :)

@CGarces
Copy link
Author

CGarces commented Nov 4, 2016

After learn how rebase commits.... done.
I have only tested RTL8189ES.
Added also RTL8188EU-AML that replace the upstream driver

@kszaq
Copy link
Owner

kszaq commented Nov 6, 2016

@CGarces I cherry-picked your first commits to libreelec-7.0 branch. I did not have time to test other commits. They look good but need to be tested before I merge them into release build.

@CGarces
Copy link
Author

CGarces commented Nov 6, 2016

Rebased

@CGarces
Copy link
Author

CGarces commented Sep 23, 2017

supersede by 2d04956

@CGarces CGarces closed this Sep 23, 2017
@kszaq
Copy link
Owner

kszaq commented Sep 25, 2017

@CGarces once again I'd like to thank you for this PR. Only recently have I had time to merge it and I decided to rework it to use as few patches as possible (none actually) and more up-to-date repos. I based it partially on your work, I hope you're not angry that I did not merge the PR.

@CGarces
Copy link
Author

CGarces commented Sep 25, 2017

I'm more than happy to have a updated version of RTL8189ES

@CGarces CGarces deleted the mainstream_modules branch September 25, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants