New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mainstream modules #7
Conversation
Thank your the PR. Can you rebase this on my I'm also not sure whether we want to use 8188EU driver from packages as it was reported to not work well with built-in chips. |
Done, only two drivers changed RTL8192EU and RTL8812AU. You have any device with 8188EU to reproduce the error? Just FYI RTL8188EU was removed from OpenELEC I can't find more information. |
Added RTL8189ES as package. Tested on my S905X device. |
Thank you! This will certainly be useful when mainstreaming S805 and S905 projects. 👍 |
Added 3 new packages |
@CGarces Thank you a lot for your input. I think at this point I will cherry-pick your commits to use upstream drivers if that's OK? For Amlogic-specific drivers there are 2 things I would like to change:
|
No problem, if you cherry-pick the commits I will remove it from the PR. If you think that use RTLxxxxxx-aml is better, it's ok for me, Drivers from https://github.com/CGarces/RTL* are from your kernel code so you have a 99% possibilities to success. We can use it as backup plan if mmallow_hardware_wifi_realtek_drivers_* not works. I'll do it ASAP. |
No rush. :) |
After learn how rebase commits.... done. |
@CGarces I cherry-picked your first commits to |
Rebased |
supersede by 2d04956 |
@CGarces once again I'd like to thank you for this PR. Only recently have I had time to merge it and I decided to rework it to use as few patches as possible (none actually) and more up-to-date repos. I based it partially on your work, I hope you're not angry that I did not merge the PR. |
I'm more than happy to have a updated version of RTL8189ES |
This PR disable some modules from kernel to use the mainstream code at packages/linux-drivers/
It allow to maintain the code up to date and sync with LibreElec repository.
I have send this PR over libreelec-7.0 with the last changes from tags, but I can rebase the PR if needed.
You can obtain a similar PR using this cherry-pick
git cherry-pick c637a0200a5ac6a19a79adc112ab831caea91f86 c80df2f000d0b735e9040414a87d53a41d5eb101 23037b828804fa47d2e7d29c4f60951c6329a14e 6b94a15ae933ab34eafb2ad9e4f196c7f2b69d9a a3dca5031b21f4a12bd303e4cb0517ef030b9282
And the additional changes from 005677ff7492ca0aa2f56d9b547d8de02c203e6a
I have compiled and tested on my S905 device unfortunately has a rtl8189es so I can't test the modules by myself.
If you think that is PR is useful, I can continue the work creating a module for other drivers like rtl8189es, the one used by my android device.