New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cssFiles + scriptsFiles argv have to be array. add remark + remar… #11

Merged
merged 2 commits into from Aug 6, 2018

Conversation

Projects
None yet
2 participants
@wildcard
Copy link
Contributor

wildcard commented Aug 5, 2018

fix cssFiles + scriptsFiles argv have to be array.
add remark + remark emoji

now you can just run remarker --cssFiles file.css instead of remarker --cssFiles file.css --cssFiles file.css

and you can use :apple: to be converted to 🍎 emoji

@kt3k

This comment has been minimized.

Copy link
Owner

kt3k commented Aug 6, 2018

@wildcard
Thanks for the contribution! cssFiles scriptFiles part of the change seems good to me.

The introduction of gulp-remark seems causing a problem. The examples don't seem working with this change. (You can test existing examples by the following steps:

cd examples/simple # or other example directory
node ../../index.js

This tool basically uses https://github.com/gnab/remark for parsing and constructing the slides (in browser). gulp-remark depends on https://github.com/remarkjs/remark, and this "remark" is totally different one and not compatible with gnab/remark.

If we process :apple: type emoji, I think we need to use more primitive tool like https://www.npmjs.com/package/node-emoji .

@kt3k

This comment has been minimized.

Copy link
Owner

kt3k commented Aug 6, 2018

I'd prefer you to revert emoji related part of the commit for the moment, and separate that change to anothor PR because other part seems no problem.

@wildcard

This comment has been minimized.

Copy link
Contributor Author

wildcard commented Aug 6, 2018

@kt3k you're right.. I've tried some things to accommodate the differences between the 2 and still didn't figured out how to preserve remarkjs special symbols..

I'll separate the PR changes for now.

@wildcard wildcard changed the title fix cssFiles + scriptsFiles argv have to be array. add remark + remar… WIP fix cssFiles + scriptsFiles argv have to be array. add remark + remar… Aug 6, 2018

@wildcard

This comment has been minimized.

Copy link
Contributor Author

wildcard commented Aug 6, 2018

@kt3k I've updated the PR. Please check if it is ok now :)

@kt3k

kt3k approved these changes Aug 6, 2018

Copy link
Owner

kt3k left a comment

This seems working on my end 👍

Thanks for the constribution!

@kt3k kt3k changed the title WIP fix cssFiles + scriptsFiles argv have to be array. add remark + remar… fix cssFiles + scriptsFiles argv have to be array. add remark + remar… Aug 6, 2018

@kt3k kt3k merged commit e2c4a8d into kt3k:master Aug 6, 2018

@wildcard

This comment has been minimized.

Copy link
Contributor Author

wildcard commented Aug 6, 2018

Cool!

@kt3k

This comment has been minimized.

Copy link
Owner

kt3k commented Aug 6, 2018

Released as v1.9.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment