New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task grouping #31

Merged
merged 10 commits into from Jul 30, 2018

Conversation

Projects
None yet
1 participant
@kt3k
Copy link
Owner

kt3k commented Jul 28, 2018

This PR adds the function to group the tasks by the levels of headings, which has been discussed in #28.


tasks

  • task_stack
  • task.children is TaskCollection
  • task.parent
  • parse hierarchy
  • update action info
  • testing parsing hierarchy
  • <!-- saku parallel --> <!-- saku parallel race -->
  • testing parallel in hierarchy
  • testing abort in hierarchy
  • Describe task grouping in README.md
  • refactor redundant things.

kt3k added some commits Jul 28, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #31    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          13     14     +1     
  Lines         298    398   +100     
======================================
+ Hits          298    398   +100
Impacted Files Coverage Δ
pkg/saku/logger.go 100% <100%> (ø) ⬆️
pkg/saku/task.go 100% <100%> (ø) ⬆️
pkg/saku/action_run.go 100% <100%> (ø) ⬆️
pkg/saku/run_options.go 100% <100%> (ø) ⬆️
pkg/saku/run.go 100% <100%> (ø) ⬆️
pkg/saku/action_info.go 100% <100%> (ø) ⬆️
pkg/saku/action_version.go 100% <100%> (ø) ⬆️
pkg/saku/task_stack.go 100% <100%> (ø)
pkg/saku/task_collection.go 100% <100%> (ø) ⬆️
pkg/saku/action_help.go 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d387a25...7043884. Read the comment docs.

@kt3k kt3k referenced this pull request Jul 28, 2018

Closed

Task grouping #30

5 of 8 tasks complete

@kt3k kt3k force-pushed the feature/grouping branch from 0e2497e to cc8b29f Jul 28, 2018

@kt3k kt3k merged commit 5f6dbe2 into master Jul 30, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to d387a25
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@kt3k kt3k deleted the feature/grouping branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment