Build failure on arm64

[4ad]

: xgene:ktap; uname -a
Linux xgene 3.19.0-defconfig+uprobes #1 SMP PREEMPT Tue Feb 10 16:27:55 CET 2015 aarch64 aarch64 aarch64 GNU/Linux
: xgene:ktap; make
    CHK libelf
make -C /lib/modules/3.19.0-defconfig+uprobes/build M=/home/aram/y/ktap modules
make[1]: Entering directory '/usr/src/linux-headers-3.19.0-defconfig+uprobes'
    CHK libelf
  CC [M]  /home/aram/y/ktap/runtime/amalg.o
In file included from /home/aram/y/ktap/runtime/amalg.c:22:0:
/home/aram/y/ktap/runtime/ktap.c: In function ‘ktapvm_ioctl’:
/home/aram/y/ktap/runtime/ktap.c:177:2: error: implicit declaration of function ‘get_unused_fd’ [-Werror=implicit-function-declaration]
  new_fd = get_unused_fd();
  ^
In file included from /home/aram/y/ktap/runtime/amalg.c:28:0:
/home/aram/y/ktap/runtime/kp_transport.c: In function ‘_trace_seq_to_user’:
/home/aram/y/ktap/runtime/kp_transport.c:67:7: error: ‘struct trace_seq’ has no member named ‘len’
  if (s->len <= s->readpos)
       ^
/home/aram/y/ktap/runtime/kp_transport.c:67:17: error: ‘struct trace_seq’ has no member named ‘readpos’
  if (s->len <= s->readpos)
                 ^
/home/aram/y/ktap/runtime/kp_transport.c:70:9: error: ‘struct trace_seq’ has no member named ‘len’
  len = s->len - s->readpos;
         ^
/home/aram/y/ktap/runtime/kp_transport.c:70:18: error: ‘struct trace_seq’ has no member named ‘readpos’
  len = s->len - s->readpos;
                  ^
/home/aram/y/ktap/runtime/kp_transport.c:73:40: error: ‘struct trace_seq’ has no member named ‘readpos’
  ret = copy_to_user(ubuf, s->buffer + s->readpos, cnt);
                                        ^
/home/aram/y/ktap/runtime/kp_transport.c:79:3: error: ‘struct trace_seq’ has no member named ‘readpos’
  s->readpos += cnt;
   ^
/home/aram/y/ktap/runtime/kp_transport.c: In function ‘_trace_seq_puts’:
/home/aram/y/ktap/runtime/kp_transport.c:90:32: error: ‘struct trace_seq’ has no member named ‘len’
  if (len > ((PAGE_SIZE - 1) - s->len)) {
                                ^
/home/aram/y/ktap/runtime/kp_transport.c:95:22: error: ‘struct trace_seq’ has no member named ‘len’
  memcpy(s->buffer + s->len, str, len);
                      ^
/home/aram/y/ktap/runtime/kp_transport.c:96:3: error: ‘struct trace_seq’ has no member named ‘len’
  s->len += len;
   ^
/home/aram/y/ktap/runtime/kp_transport.c: In function ‘trace_print_timestamp’:
/home/aram/y/ktap/runtime/kp_transport.c:139:2: error: void value not ignored as it ought to be
  return trace_seq_printf(s, "%5lu.%06lu: ", secs, usec_rem);
  ^
/home/aram/y/ktap/runtime/kp_transport.c: In function ‘print_trace_fmt’:
/home/aram/y/ktap/runtime/kp_transport.c:160:29: error: ‘struct trace_seq’ has no member named ‘len’
   iter->seq.buffer[iter->seq.len - 1] = '\0';
                             ^
/home/aram/y/ktap/runtime/kp_transport.c:161:12: error: ‘struct trace_seq’ has no member named ‘len’
   iter->seq.len--;
            ^
/home/aram/y/ktap/runtime/kp_transport.c: In function ‘print_trace_stack’:
/home/aram/y/ktap/runtime/kp_transport.c:189:3: error: invalid use of void expression
   if (!trace_seq_printf(&iter->seq, " => %s\n", str))
   ^
/home/aram/y/ktap/runtime/kp_transport.c: In function ‘print_trace_line’:
/home/aram/y/ktap/runtime/kp_transport.c:240:3: error: invalid use of void expression
   if (!trace_seq_printf(&iter->seq, "%s", str))
   ^
/home/aram/y/ktap/runtime/kp_transport.c: In function ‘tracing_read_pipe’:
/home/aram/y/ktap/runtime/kp_transport.c:401:22: error: ‘struct trace_seq’ has no member named ‘len’
   int len = iter->seq.len;
                      ^
/home/aram/y/ktap/runtime/kp_transport.c:406:13: error: ‘struct trace_seq’ has no member named ‘len’
    iter->seq.len = len;
             ^
/home/aram/y/ktap/runtime/kp_transport.c:412:16: error: ‘struct trace_seq’ has no member named ‘len’
   if (iter->seq.len >= cnt)
                ^
/home/aram/y/ktap/runtime/kp_transport.c:426:15: error: ‘struct trace_seq’ has no member named ‘readpos’
  if (iter->seq.readpos >= iter->seq.len)
               ^
/home/aram/y/ktap/runtime/kp_transport.c:426:36: error: ‘struct trace_seq’ has no member named ‘len’
  if (iter->seq.readpos >= iter->seq.len)
                                    ^
In file included from /home/aram/y/ktap/runtime/amalg.c:30:0:
/home/aram/y/ktap/runtime/kp_events.c: In function ‘kp_event_tostr’:
/home/aram/y/ktap/runtime/kp_events.c:77:14: error: ‘struct trace_seq’ has no member named ‘len’
   int len = s->len >= PAGE_SIZE ? PAGE_SIZE - 1 : s->len;
              ^
/home/aram/y/ktap/runtime/kp_events.c:77:52: error: ‘struct trace_seq’ has no member named ‘len’
   int len = s->len >= PAGE_SIZE ? PAGE_SIZE - 1 : s->len;
                                                    ^
In file included from /home/aram/y/ktap/runtime/amalg.c:31:0:
/home/aram/y/ktap/runtime/lib_base.c: In function ‘kplib_printf’:
/home/aram/y/ktap/runtime/lib_base.c:78:17: error: ‘struct trace_seq’ has no member named ‘len’
  seq->buffer[seq->len] = '\0';
                 ^
/home/aram/y/ktap/runtime/lib_base.c:79:41: error: ‘struct trace_seq’ has no member named ‘len’
  kp_transport_write(ks, seq->buffer, seq->len + 1);
                                         ^
In file included from ./arch/arm64/include/asm/dma-mapping.h:27:0,
                 from include/linux/dma-mapping.h:82,
                 from include/linux/skbuff.h:34,
                 from include/linux/if_ether.h:23,
                 from include/uapi/linux/ethtool.h:17,
                 from include/linux/ethtool.h:16,
                 from include/linux/netdevice.h:43,
                 from include/net/inet_sock.h:24,
                 from /home/aram/y/ktap/runtime/lib_net.c:22,
                 from /home/aram/y/ktap/runtime/amalg.c:36:
./arch/arm64/include/asm/xen/hypervisor.h: At top level:
./arch/arm64/include/asm/xen/hypervisor.h:1:50: fatal error: ../../arm/include/asm/xen/hypervisor.h: No such file or directory
 #include <../../arm/include/asm/xen/hypervisor.h>
                                                  ^
cc1: some warnings being treated as errors
compilation terminated.
scripts/Makefile.build:257: recipe for target '/home/aram/y/ktap/runtime/amalg.o' failed
make[2]: *** [/home/aram/y/ktap/runtime/amalg.o] Error 1
Makefile:1382: recipe for target '_module_/home/aram/y/ktap' failed
make[1]: *** [_module_/home/aram/y/ktap] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-3.19.0-defconfig+uprobes'
Makefile:69: recipe for target 'mod' failed
make: *** [mod] Error 2
: xgene:ktap; 
: xgene:ktap; 

[jimenezrick]

I have the same issue on x86_64, maybe ktap needs an update for the latests kernels? Those fields in struct trace_seq look missing in my /usr/lib/modules/4.0.1-1-ARCH/build/include/linux/trace_seq.h.