Fix compiler error. #19

Merged
merged 1 commit into from Aug 31, 2013

Conversation

Projects
None yet
2 participants
@nbaum

nbaum commented Aug 4, 2013

I had to declare this function to get it to compile.

No doubt this should be scoped with a KDEV_PLUGIN_VERSION, but I don't know what version the function is available in. 馃槃

@zoltanp

This comment has been minimized.

Show comment Hide comment
@zoltanp

zoltanp Aug 9, 2013

Owner

Thanks you for the proposed contribution :)

Based on kdevplatform's source code ( git://anongit.kde.org/kdevplatform ), the methods needed for compilation have been introduced in commit 2bbcf142edc4db48b779529c4a78fc09bacd832e:

Follows: v1.4.0
Precedes: v1.4.90

    support pasting items from outside the project by using a KUrl instead of ProjectBasItem

Also by checking with git, this commit is in the releases:

kdevplatform$ git tag --contains 2bbcf142edc4db48b779529c4a78fc09bacd832e
v1.4.90
v1.5.0
v1.5.1

So I guess the check should be: KDEV_PLUGIN_VERSION >= 1.4.90

Owner

zoltanp commented Aug 9, 2013

Thanks you for the proposed contribution :)

Based on kdevplatform's source code ( git://anongit.kde.org/kdevplatform ), the methods needed for compilation have been introduced in commit 2bbcf142edc4db48b779529c4a78fc09bacd832e:

Follows: v1.4.0
Precedes: v1.4.90

    support pasting items from outside the project by using a KUrl instead of ProjectBasItem

Also by checking with git, this commit is in the releases:

kdevplatform$ git tag --contains 2bbcf142edc4db48b779529c4a78fc09bacd832e
v1.4.90
v1.5.0
v1.5.1

So I guess the check should be: KDEV_PLUGIN_VERSION >= 1.4.90

@zoltanp

This comment has been minimized.

Show comment Hide comment
@zoltanp

zoltanp Aug 9, 2013

Owner

The releases 1.4.0 and 1.4.1 of kdevplatform have
#define KDEVELOP_PLUGIN_VERSION 14
while the release 1.4.90 has
#define KDEVELOP_PLUGIN_VERSION 15
so the check for proper KDevelop / KDevPlatform version should be:

# if KDEV_PLUGIN_VERSION >= 15

After adding that check, this pull request is ready for merge in my opinion.

Owner

zoltanp commented Aug 9, 2013

The releases 1.4.0 and 1.4.1 of kdevplatform have
#define KDEVELOP_PLUGIN_VERSION 14
while the release 1.4.90 has
#define KDEVELOP_PLUGIN_VERSION 15
so the check for proper KDevelop / KDevPlatform version should be:

# if KDEV_PLUGIN_VERSION >= 15

After adding that check, this pull request is ready for merge in my opinion.

zoltanp added a commit that referenced this pull request Aug 31, 2013

Merge pull request #19 from nbaum/master
Add stub for KTLProjectManager::copyFilesAndFolders from kdevplatform.

This new method has appeared first in kdevplatform 1.4.90.

The releases 1.4.0 and 1.4.1 of kdevplatform have
#define KDEVELOP_PLUGIN_VERSION 14
 while the release 1.4.90 has
#define KDEVELOP_PLUGIN_VERSION 15
 so the check for proper KDevelop / KDevPlatform version should be:
# if KDEV_PLUGIN_VERSION >= 15

After adding that check, this pull request is ready for merge in my opinion.

@zoltanp zoltanp merged commit 3689392 into ktechlab:master Aug 31, 2013

@zoltanp

This comment has been minimized.

Show comment Hide comment
@zoltanp

zoltanp Aug 31, 2013

Owner

@nbaum Pull request merged as originally proposed. Thank you for your contribution.

Owner

zoltanp commented Aug 31, 2013

@nbaum Pull request merged as originally proposed. Thank you for your contribution.

zoltanp added a commit that referenced this pull request Nov 6, 2016

Merge pull request #19 from nbaum/master
Add stub for KTLProjectManager::copyFilesAndFolders from kdevplatform.

This new method has appeared first in kdevplatform 1.4.90.

The releases 1.4.0 and 1.4.1 of kdevplatform have
#define KDEVELOP_PLUGIN_VERSION 14
 while the release 1.4.90 has
#define KDEVELOP_PLUGIN_VERSION 15
 so the check for proper KDevelop / KDevPlatform version should be:
# if KDEV_PLUGIN_VERSION >= 15

After adding that check, this pull request is ready for merge in my opinion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment