Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jade branch #11

Closed
progtologist opened this issue Jan 15, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@progtologist
Copy link
Contributor

commented Jan 15, 2016

I have made some minor changes regarding eigen compatibility with Jade, please create a jade branch so I can issue a pull request.

Thx ;-)

@130s

This comment has been minimized.

Copy link
Collaborator

commented Jan 15, 2016

Correct me if I'm wrong; there's a migration notice about Eigen in Jade where you still can keep using the same code for Jade and prior distros.
So if the change you have is about this cmake, my opinion is to try the solution in the link above to use the same code.

Branching works as a clean solution for the difference between distros, but it can inject disorder unless the repo is maintained consistently (don't get me wrong, I don't mean at all this repo is not maintained. It's just I've seen several repos that fell into a bad loop).
2cents from me.

@progtologist

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2016

I think that the "If you want to support both" part of the sentence refers to jade and k-turtle, but not indigo. I have also changed the preprocessor include paths to be <Eigen/...> (which should be the correct path if the Eigen headers are correctly found using cmake variables) and not <eigen3/Eigen/...>

@130s

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2016

I have also changed the preprocessor include paths to be (which should be the correct path if the Eigen headers are correctly found using cmake variables) and not

I'm not cmake-eigen guru but sounds like this is a good reason to create branch for jade.
So +1
I don't have a right to do so. Maybe @fevb

Below is just a comment.

I think that the "If you want to support both" part of the sentence refers to jade and k-turtle, but not indigo.

My impression from the wiki statement was that for the situation described in wiki, we don't need to do anything for Jade.

@fevb

This comment has been minimized.

Copy link
Member

commented Jan 18, 2016

Hi, sure I'll create a jade branch, sounds reasonable

@fevb fevb closed this Jan 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.