Skip to content

Tom Klingenberg
ktomk

  • lastflood GmbH (et al.)
  • Joined on
ktomk commented on pull request netz98/n98-magerun#762
@ktomk

@brobie: Thanks for your updated PR. I've left some comments on the commit but those are merely little details that could be touched but I don't th…

@ktomk
  • @ktomk c0c3378
    [TASK] #717 Check requirements in db:dump
ktomk commented on commit brobie/n98-magerun@4e7c716750
@ktomk

the test only works with enterprise edition. just leaving a note, have not found a working solution to mock this yet.

ktomk commented on commit brobie/n98-magerun@4e7c716750
@ktomk

I'm fine with returning early if nothing to do. Helps keeping indentation levels lower.

ktomk commented on commit brobie/n98-magerun@4e7c716750
@ktomk

Outputting the number of admin accounts unlocked would be nice.

ktomk commented on commit brobie/n98-magerun@4e7c716750
@ktomk

It's first asked but perhaps there is nothing to unlock then? Maybe interactivity should be the other way round: only if there are all to unlock (a…

ktomk commented on commit brobie/n98-magerun@4e7c716750
@ktomk

it's no should. $unlockAll is sufficient.

ktomk commented on issue netz98/n98-magerun#717
@ktomk

@johnhughes1984: That's because commands that are not enabled count technically as undefined in the Symfony2 console framework we use. At that plac…

@ktomk
ktomk reopened pull request pear/Net_URL2#12
@ktomk
Add legacy include path option.
1 commit with 7 additions and 2 deletions
ktomk closed pull request pear/Net_URL2#12
@ktomk
Add legacy include path option.
ktomk commented on pull request pear/Net_URL2#12
@ktomk

So for those who manually port pear packages to be used with composer. Hmm. I'm a bit biased here but at least it should be possible to have two br…

ktomk commented on pull request netz98/n98-magerun#766
@ktomk

I'm fine with more consistency, but for review it would require me to obtain those zip files, also the older ones. Do you have a source for these? A…

@ktomk
  • @ktomk 0e34d04
    Fix fwrite() truncation on resource
ktomk commented on pull request magento/magento2#3091
@ktomk

Hm, I then guess that 0 is an error code for the underlying operation and it should be treated that way. I've taken a peek into streams in PHP, rea…

ktomk commented on pull request pear/Net_URL2#12
@ktomk

@cweiske: Hmm, it works the PSR-0 way with the PEAR package. That has not been changed.PSR-0 is 100% perfectly working, just grab the package, it's…

ktomk commented on pull request pear/Net_URL2#12
@ktomk

Upstream report was here: Bug #20531 - Net_URL2 2.2.0 has switched to classmap autoloader (Apr 2015). Also seeing traction by pear/HTTP_Request2#12.

ktomk commented on pull request pear/Net_URL2#12
@ktomk

Thanks for your report. IIRC there was (?) an issue report for HTTP_Request2 on Github about it, but I can't find it right now, I would have liked …

ktomk commented on pull request magento/magento2#3091
@ktomk

@MaxSavich: If the reason that 0 bytes have been written is not an error (in the disk full example you give) the program will continue to write unt…

@ktomk
Remove usage of non-existent DialogHelper
ktomk commented on issue netz98/n98-magerun#563
@ktomk

@ozzyogkush: I would then close this issue for now as I believe this problem is fixed in the current version. If I'm wrong, we can re-open this again.

@ktomk
BaseURL Check Error
ktomk commented on issue netz98/n98-magerun2#172
@ktomk

The fix is now part of the development version. You can do a self-upgrade to the unstable variant to obtain it. It will become part of the next sta…

ktomk deleted branch bugfix/172-base-url-check at netz98/n98-magerun2
@ktomk
  • @ktomk 168fd5a
    [FIX] #172 Base-URL check on IP addresses
ktomk commented on issue netz98/n98-magerun2#172
@ktomk

@simkea: My fault, sorry for being that imprecise about the full command, the path needs to be given: n98-magerun2.phar config:get "*/base_url" th…

ktomk commented on issue netz98/n98-magerun2#172
@ktomk

@simkea: Can you run the config:get command and check those config paths with it, too? From what I see in your report is, that the base-URLs are em…

@ktomk
  • @ktomk 24eb931
    [TASK] streamline CheckCommand with MR2
@ktomk
  • @ktomk 24eb931
    [TASK] streamline CheckCommand with MR2
Something went wrong with that request. Please try again.