Advanced scoring #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2016 13:58
…nchronous loading to speed up searches.
…complex structure allowing to implement rules for selecting the files. Some println are there for debug / understanding - will be removed later on.
Removed temporary "bangs!" tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I unplugged the implementation based on a score (Int) for ponderation, to something a bit more evolved now bringing for each part of the pattern if it is found, and at which distance.
For now, a score calculation is still made (kind of a basic one, mimicking the previous one), but in the future, we'll be able to implement more advanced rules such as minimizing the distance between letters, or minimizing close errors (like 2 errors in a row are worse than 2 errors separated by some letters), etc.
I'll let you have look and tell me if there's something you would modify ;)