Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] HttpClient(CIOEngine) #800

Closed
revintec opened this issue Dec 15, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@revintec
Copy link

commented Dec 15, 2018

  1. aSocket(...) may throw IOExceptions and causing semaphore to leak, related code:
    val connection = withTimeoutOrNull(connectTimeout) { connectionFactory.connect(address) }

    return aSocket(selector).tcpNoDelay().tcp().connect(address)
  2. retryAttempts should be named connectionAttempts or we should be using repeat(retryAttempts+1)

@e5l e5l self-assigned this Dec 15, 2018

@e5l e5l added the bug label Dec 15, 2018

@revintec

This comment has been minimized.

Copy link
Author

commented Dec 26, 2018

@e5l any update on this?

cy6erGn0m added a commit that referenced this issue Dec 28, 2018

cy6erGn0m added a commit that referenced this issue Dec 28, 2018

cy6erGn0m added a commit that referenced this issue Dec 28, 2018

@e5l e5l added this to the 1.1.2 milestone Jan 10, 2019

@e5l

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

The fix in master.

@e5l e5l closed this Jan 10, 2019

@revintec

This comment has been minimized.

Copy link
Author

commented Jan 12, 2019

Thanks, I'll try it when the new version is released

schleinzer pushed a commit to schleinzer/ktor that referenced this issue Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.