Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call _setup_logging earlier. #5

Merged
merged 1 commit into from Nov 17, 2015

Conversation

@zenhack
Copy link
Contributor

commented Nov 17, 2015

If this isn't done before the first attempt to use the logger, instead
of the logged text, the user will see:

No handlers could be found for logger "simp_le"

Previously, forgetting -d/--vhost would trigger the behavior.

Thanks for the tool, btw.

@kuba

View changes

simp_le.py Outdated
@@ -765,12 +765,12 @@ def _setup_logging(verbose):

def _main(cli_args):
args = create_parser().parse_args(cli_args)
_setup_logging(args.verbose)

This comment has been minimized.

Copy link
@kuba

kuba Nov 17, 2015

Owner

I think we actually don't want it to be called in --test case. Can you please change it to:

if args.test:
  ...
_setup...
if args.vhosts ...

This comment has been minimized.

Copy link
@zenhack

zenhack Nov 17, 2015

Author Contributor

Quoting Jakub Warmuz (2015-11-17 02:00:16)

I think we actually don't want it to be called in --test case. Can
you
please change it to:

...

Done.

@kuba

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2015

Well spotted. Welcome to the project, thanks for the contribution! :)

Call _setup_logging earlier.
If this isn't done before the first attempt to use the logger, instead
of the logged text, the user will see:

    No handlers could be found for logger "simp_le"

Previously, forgetting -d/--vhost would trigger the behavior.

@zenhack zenhack force-pushed the zenhack:logging-fix branch from bc13212 to 7a0c564 Nov 17, 2015

@kuba

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2015

Thanks a lot!

@kuba kuba merged commit 7a0c564 into kuba:master Nov 17, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@zenhack zenhack deleted the zenhack:logging-fix branch Nov 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.