Code refactor #17
Merged
Code refactor #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prettier but with an incorrect name
hkube-ci
pushed a commit
that referenced
this pull request
Jan 3, 2019
* [+] Add eslint and update npm dependencies * [+] Styled Component refactor start * [~] Header as styled-comp * [+] migration to Style-Component (1/2) * [+] withState/Stateless components * [~] Minor * [~] cant npm start * [~] fixing * [+] containers - dumb * [+] containers - dumb * [+] containers - dumb * [-] remove execute button * [+] No errors, migrate to scss * [+] add sass * change from the ugly play icon with a circle around to something much prettier but with an incorrect name * [+] Fix execute button, ready for merge * [+] Fix all errors * [~] Typo fix .... bump version [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Refactoring
eslintstyle-componentssassTable check list refactor
Questions
socket middlware: trying to register topic PROGRESS twiceNice to have
This change is