Add label selector to exclude deployments and cronjobs

[dirk39]

Hello, with this PR we want to fix issue #172. We noticed that the behaviour of the Cronjob selector differs from the deployment. Do you think we can replicate the deployment behaviour in the cronjob? So we can add the matchLabels functionality.

[ludusrusso]

LGTM

[coveralls]

Pull Request Test Coverage Report for Build 3614548454

• 51 of 56 (91.07%) changed or added relevant lines in 6 files are covered.
• 45 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.5%) to 85.868%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/sleepinfo/cronjobs/testutil.go	2	3	66.67%
api/v1alpha1/sleepinfo_webhook.go	4	6	66.67%
controllers/sleepinfo/cronjobs/cronjobs.go	14	16	87.5%

Files with Coverage Reduction	New Missed Lines	%
controllers/sleepinfo/sleepinfo_controller.go	45	70.56%

Totals
Change from base Build 3436741837:	0.5%
Covered Lines:	875
Relevant Lines:	1019

---

💛 - Coveralls

[davidebianchi]

Hi @dirk39, thank you for the PR. Great work!

I didn't know the Open Source Saturday meetup, very interesting!

Here a couple of comments.

The implementation of the CronJob differs because it uses the FieldSelector query, do you mean this? This should be more performant, as it permits to get only the resources needed. It is not possible to add this filter using the FieldSelector?
Otherwise, yes I suppose that it is possible to change the implementation to add this filter.

[dirk39]

Hi @davidebianchi , the general idea was to uniform the behavior of the deployment and cronjob filter. I think that the deployment solution is easier to maintain but if you prefer I can have a look to the fieldSelector to see if they support the labelMatch.

[davidebianchi]

CronJobs have been made after Deployments, so when I developed the Deployments I didn't know the fieldSelector. But with the labels, there might be a large number of Deployments and CronJobs to exclude so it could be better to use it. So yes, if you want to see for the support it would be better, but also this implementation is ok for me.

[davidebianchi]

Hi @dirk39, is it the introduction of labelSelector finished? I see that the last commit contains is in wip.

[dirk39]

Hi @davidebianchi , I've introduced the labelselector for the cronjob but I have to add tests to validate the solution.

[dirk39]

Hi @davidebianchi, I'm sorry for my delay. I've added unit and e2e tests for the CJ. Let me know if it looks good to you

[davidebianchi]

LGTM!

Thanks for the contribution, great work!