Add support of more resources

[davidebianchi]

What type of resources should be handled by kube-green?

• traefik ingress route
• Replica Sets
• StatefulSet

[ctienshi]

Is it possible to use Kube-green with replica sets, daemon sets etc so the nodes could scale down to zero?

[jwcesign]

Can we also delete node and restore it for some public cloud, like gcp? cc @davidebianchi

[davidebianchi]

Is it possible to use Kube-green with replica sets, daemon sets etc so the nodes could scale down to zero?

For replica sets yes, we could add the support. For the daemon, there will be one per node so I don't think it's ok to remove programmatically. If the cluster autoscaler is enabled, the node should downscale automatically. If it is not, you should modify the deamon accordingly. If you have any problem about this, you can see this docs to troubleshooting the nodes downscaling

Can we also delete node and restore it for some public cloud, like gcp?

Yes, it is possible to do it with the node autoscaler on gcp. The previous link could help you?

[jgerber-sbb]

Support for DeploymentConfig (OpenShift specific) would be nice:
https://docs.openshift.com/container-platform/latest/applications/deployments/what-deployments-are.html
https://docs.openshift.com/container-platform/latest/rest_api/workloads_apis/deploymentconfig-apps-openshift-io-v1.html

[djmcgreal-cc]

+StatefulSets? I'd like to make a PR or so, but want to gauge whether it's already been thought of but there's a more fundamental difficulty in the way?

I'd like to deploy this to our pre-production clusters but in our case, there's not much point unless we can take the node down.
Thanks for this!

[djmcgreal-cc]

And possibly a some support for arbitrary configuration for CRDs in the SleepInfo, like a selector and strategic/merge/json patch?

[davidebianchi]

Hi @djmcgreal-cc! Sure, we could add the StatefulSets. I haven't looked yet for this resource in the detail, but it has the replicas configuration if I well remember, so I suppose it could be add easily.
Do you have some nodes with only some StatefulSets?

And possibly a some support for arbitrary configuration for CRDs in the SleepInfo, like a selector and strategic/merge/json patch?

What do you mean with arbitrary configuration? Can you add more details on the expected use case or some more description on what can be done?
Maybe a generic way to describe which resource should be managed and what are the changes which should be done to disable the specific resource?

[djmcgreal]

Precisely. So that the project doesn’t need to track all CRDs in the ecosystem

[potitoaghilar]

Hi @djmcgreal-cc! Sure, we could add the StatefulSets. I haven't looked yet for this resource in the detail, but it has the replicas configuration if I well remember, so I suppose it could be add easily. Do you have some nodes with only some StatefulSets?

And possibly a some support for arbitrary configuration for CRDs in the SleepInfo, like a selector and strategic/merge/json patch?

What do you mean with arbitrary configuration? Can you add more details on the expected use case or some more description on what can be done? Maybe a generic way to describe which resource should be managed and what are the changes which should be done to disable the specific resource?

We are also interested in StatefulSet scaling to zero. In our case we have StatefulSets and Deployments on same node.

[bygui86]

Maybe it could be useful a catalog of CRDs...
https://github.com/datreeio/CRDs-catalog

[davidebianchi]

Hi all, I'm thinking about something like json patch to try to generalize the support on various resources.
So, something like:

  patchesJson6902:
    - target:
        version: "apps/v1"
        kind: Deployment
        # labelSelector: "env=dev"
      patch:
        key: "#/spec/replicas"
        value: 0
    - target:
        apiVersion: "batch/v1"
        kind: CronJob
      patch:
        key: "#/spec/suspend"
        value: true

In this way, we could also add some first class resources (like deployment and cronjobs) which are supported by default, and the user could also add the patch for a custom CRD which want to manage.
What do you think about? Any hint on this?

[djmcgreal-cc]

Sounds totally sensible to me