fix: align metrics service names and reuse object metadata #2147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes inconsistent service naming and metadata handling across the metrics reconciler functions in fluentd, fluentbit and syslogng. It also refactors the code to reuse object metadata to ensure consistent behaviour in both present and absent states.
objectMetadatavariable initialized at the top of each reconciler function. This replaces repeated calls to*ObjectMeta(...)when building the Service or ServiceMonitor objects."-metrics"or"-buffer-metrics"suffix) is targeted for deletion. Previously, the “absent” branch sometimes used a legacy suffix (e.g."-monitor"), causing the actual metrics Service to be orphaned — this could break metrics cleanup and cause stale or duplicated resources.