Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: Remove deprecated util try_flatten_ helpers #1019

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

clux
Copy link
Member

@clux clux commented Sep 21, 2022

These two were slated for removal in 0.75 and have had alternatives listed since 0.72 (5 months).

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-remove changelog remove category for prs label Sep 21, 2022
@clux clux added this to the 0.76.0 milestone Sep 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1019 (8003704) into master (575b3f4) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
+ Coverage   71.93%   72.02%   +0.08%     
==========================================
  Files          65       65              
  Lines        4647     4643       -4     
==========================================
+ Hits         3343     3344       +1     
+ Misses       1304     1299       -5     
Impacted Files Coverage Δ
kube-runtime/src/utils/mod.rs 62.96% <ø> (+4.34%) ⬆️
kube-runtime/src/wait.rs 71.69% <0.00%> (+1.88%) ⬆️

Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@clux clux merged commit efe2176 into master Sep 22, 2022
@clux clux deleted the rm-deprecated-try-flatten branch September 22, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-remove changelog remove category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants