Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExecConfig::drop_env to filter host evars for auth providers #1062

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Add ExecConfig::drop_env to filter host evars for auth providers #1062

merged 2 commits into from
Nov 1, 2022

Conversation

aviramha
Copy link
Contributor

Solves #1060

@aviramha aviramha changed the title Controllabl exec control environment passed to auth exec Oct 28, 2022
@aviramha
add drop_env to ExecConfig to control passed environment variables
2c59a59 
Signed-off-by: Aviram Hassan <aviramyhassan@gmail.com>
@clux clux added the changelog-add changelog added category for prs label Oct 28, 2022
@clux clux added this to the 0.77.0 milestone Oct 28, 2022
@clux clux changed the title control environment passed to auth exec Add ExecConfig::drop_env to filter out host evars passed to auth providers Oct 28, 2022
@clux clux changed the title Add ExecConfig::drop_env to filter out host evars passed to auth providers Add ExecConfig::drop_env to filter host evars for auth providers Oct 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #1062 (2c279d9) into main (e104bea) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
- Coverage   72.32%   72.29%   -0.03%     
==========================================
  Files          65       65              
  Lines        4704     4707       +3     
==========================================
+ Hits         3402     3403       +1     
- Misses       1302     1304       +2
Impacted Files Coverage Δ
kube-client/src/client/auth/mod.rs 56.66% <0.00%> (-0.97%) ⬇️
kube-client/src/config/file_config.rs 74.35% <ø> (ø)
kube-runtime/src/wait.rs 71.69% <0.00%> (+1.88%) ⬆️

@aviramha @clux
Update kube-client/src/config/file_config.rs
2c279d9 
Co-authored-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: Aviram Hassan <aviramyhassan@gmail.com>
@aviramha aviramha requested a review from clux October 29, 2022 16:15
@aviramha
Copy link
Contributor Author

Suggested change committed.

@aviramha
Copy link
Contributor Author

Anything needed from my side atm?

@clux
Copy link
Member

clux commented Oct 30, 2022

Nah, all good, I was just giving a little time to see if anyone else had input. Happy to merge this, and will if no one else comments upstream or here for the next couple of days.

@clux clux linked an issue Oct 30, 2022 that may be closed by this pull request
control env passed to auth_exec #1060
Closed
@nightkr
Copy link
Member

nightkr commented Oct 31, 2022

👍 from me as long as it's #[serde(skip)] until there's upstream consensus.

@nightkr nightkr added the config Kube config related label Oct 31, 2022
@clux clux merged commit 9a07666 into kube-rs:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
changelog-add changelog added category for prs config Kube config related
Projects
None yet
Milestone
0.77.0
Development

Successfully merging this pull request may close these issues.

control env passed to auth_exec
4 participants
@aviramha @codecov-commenter @clux @nightkr