Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tracing dependency to 0.1.36 #1070

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Bump tracing dependency to 0.1.36 #1070

merged 1 commit into from
Nov 3, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Nov 2, 2022

This was already required in practice, we just forgot to bump the version bound accordingly.

Fixes #1069.

@nightkr nightkr added bug Something isn't working changelog-fix changelog fix category for prs labels Nov 2, 2022
@nightkr nightkr requested a review from a team November 2, 2022 23:30
@nightkr nightkr self-assigned this Nov 2, 2022
This was already required in practice, we just forgot to bump the
version bound accordingly. Fixes #1069.

Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
@nightkr
Copy link
Member Author

nightkr commented Nov 2, 2022

I'm not sure I'd say this warrants a patch release, since there's a pretty trivial workaround ("just run cargo update"). On the other hand, shipping a version with broken bounds makes life annoying for anyone trying to use -Z minimal-versions, which would be an argument in favour of even yanking the .0.

@jesperpedersen
Copy link

Having a patch release with this fix would be great

@jesperpedersen
Copy link

Should it be 0.1.37 ?

@nightkr
Copy link
Member Author

nightkr commented Nov 3, 2022

Should it be 0.1.37 ?

The change that we depend on was introduced in 0.1.36. This is just the minimum bound, most users will still get 0.1.37 anyway unless they have a reason to lock it to something lower.

@nightkr nightkr merged commit f6ca7df into main Nov 3, 2022
@nightkr nightkr deleted the bugfix/tracing-0.1.36 branch November 3, 2022 00:10
@jesperpedersen
Copy link

Thanks !

@clux clux added this to the 0.77.0 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid argument to Span::record in kube-client
4 participants