Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on azure auth not being supported #1082

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

goenning
Copy link
Contributor

@goenning goenning commented Nov 17, 2022

Signed-off-by: goenning me@goenning.net

Motivation

It's reasonable not to support the deprecated azure auth provider, but the error message should guide users to an alternative, like kubectl does.

Solution

Improve error message. This should close #501 IMO

Signed-off-by: goenning <me@goenning.net>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good way to deal with that issue given it's now gone in 1.25.

@clux clux added the changelog-fix changelog fix category for prs label Nov 17, 2022
@clux clux added this to the 0.77.0 milestone Nov 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1082 (18d49e1) into main (34af570) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   72.48%   72.45%   -0.04%     
==========================================
  Files          65       65              
  Lines        4757     4759       +2     
==========================================
  Hits         3448     3448              
- Misses       1309     1311       +2     
Impacted Files Coverage Δ
kube-client/src/client/auth/mod.rs 56.04% <0.00%> (-0.63%) ⬇️

@clux clux merged commit e9f640d into kube-rs:main Nov 17, 2022
@clux clux mentioned this pull request Nov 17, 2022
aviramha pushed a commit to metalbear-co/kube that referenced this pull request Nov 19, 2022
be more explicit on azure auth not being supported

Signed-off-by: goenning <me@goenning.net>

Signed-off-by: goenning <me@goenning.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for Azure oidc auth
3 participants