Fix interactivity in auth exec #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: armandpicard <armandpicard71@gmail.com>
Signed-off-by: armandpicard <armandpicard71@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 72.67% 72.47% -0.21%
==========================================
Files 65 65
Lines 4835 4847 +12
==========================================
- Hits 3514 3513 -1
- Misses 1321 1334 +13
|
clux
approved these changes
Nov 17, 2022
kazk
reviewed
Nov 17, 2022
Co-authored-by: kazk <kazk.dev@gmail.com> Signed-off-by: Eirik A <sszynrae@gmail.com>
clux
reviewed
Dec 10, 2022
|
Merging this, it's a clean non-breaking change judging by the Command docs. Sorry for the delay, and thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: armandpicard armandpicard71@gmail.com
Motivation
Adding support for interactivity in auth exec and putting this information to the executed programs is needed; especialy on Windows (#1046 ).
Solution
I've added simple support for
interactiveModeby giving parent process stdin to child process if needed and give information about interactivity with theKUBERNETES_EXEC_INFOenv variable.