Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] skip window creation on auth exec #1095

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

goenning
Copy link
Contributor

@goenning goenning commented Dec 2, 2022

Signed-off-by: goenning me@goenning.net

Motivation

When using kube-rs on a Windows GUI application, the auth exec is showing a terminal window during execution. It often takes less than 1 second, but it's noticeable enough to become annoying :)

2022-12-02-11-32-00.mp4

Solution

use the CREATE_NO_WINDOW flag to omit that.

Signed-off-by: goenning <me@goenning.net>
Signed-off-by: goenning <me@goenning.net>
Signed-off-by: goenning <me@goenning.net>
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #1095 (a773201) into main (be05e7c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   72.66%   72.66%           
=======================================
  Files          65       65           
  Lines        4832     4832           
=======================================
  Hits         3511     3511           
  Misses       1321     1321           
Impacted Files Coverage Δ
kube-client/src/client/auth/mod.rs 56.02% <ø> (ø)

Co-authored-by: kazk <kazk.dev@gmail.com>
Signed-off-by: Guilherme Oenning <me@goenning.net>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible to me

@clux clux added this to the 0.77.0 milestone Dec 3, 2022
@clux clux added the changelog-change changelog change category for prs label Dec 3, 2022
@clux clux merged commit e8fdf08 into kube-rs:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants