exec: ensure certs always end with a new line

[goenning]

Signed-off-by: goenning me@goenning.net

Motivation

While testing it changes from #1089, I got this error:

1: failed to deserialize PEM-encoded chain of certificates: error:0908F066:PEM routines:get_header_and_data:bad end line:crypto/pem/pem_lib.c:856:

It worked on kubectl, but not on kube-rs.

Solution

After some digging I noticed that PEM-encoded was missing a \n at the end, which seems to be what OpenSSL expects. Apparently Go is a bit more flexible with this and it's ok to not end with a new line.

This PR ensures that certs always end with a new line. OpenSSL doesn't seem to care about ending with double new lines, so this PR simply appends a new line regardless if it already ends in one. Alternatively we could check before pushing.

[codecov-commenter]

Codecov Report

Merging #1096 (cb9915a) into main (b60202c) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   72.62%   72.59%   -0.04%     
==========================================
  Files          65       65              
  Lines        4819     4821       +2     
==========================================
  Hits         3500     3500              
- Misses       1319     1321       +2     

Impacted Files	Coverage Δ
kube-client/src/client/config_ext.rs	48.07% <0.00%> (-1.93%)	⬇️