Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little extra help since we're requiring signed-off commits #3111

Merged
merged 1 commit into from Jul 9, 2021

Conversation

absoludity
Copy link
Contributor

Description of the change

Since we say in the CONTRIBUTING.md guidelines that we require DCO sign-off on all commits, I've added the DCO bot to check PRs.

This update just has a little extra info to help when people find they need to do sign-off retrospectively, as well as ensuring it's in all commits for the project if they want.

Benefits

Avoid frustration with DCO sign-off.

Possible drawbacks

None that I can see.

This may change if we switch to require a CLA instead.

Signed-off-by: Michael Nelson <minelson@vmware.com>
Copy link
Member

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the information. I don't know if we should directly move to CLA instead of DCO, but, since we are requiring DCO atm, it's a great addition.

@antgamdia
Copy link
Member

antgamdia commented Jul 8, 2021

I think there's an easier way to achieve it by appending --signoff

git commit -m "whatever" --signoff

https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff

Also, in vscode:

image

@absoludity
Copy link
Contributor Author

I think there's an easier way to achieve it by appending --signoff

git commit -m "whatever" --signoff

Yes, that's already mentioned earlier. The new section is about (1) how to deal with a situation where you've already got a bunch of commits and (2) how to avoid needing to remember.

As mentioned, I've switched the DCO bot off again to avoid churn of processes until next iteration when we discuss, but will land this just in case we decide to re-enable it.

@absoludity absoludity merged commit b8339e3 into vmware-tanzu:master Jul 9, 2021
@absoludity absoludity deleted the more-dco-info branch July 9, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants