Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chart repo and chartsvc sources #711

Merged
merged 6 commits into from Oct 9, 2018

Conversation

prydonius
Copy link
Contributor

@prydonius prydonius commented Oct 9, 2018

In #672 we decided upon moving the chart-repo and chartsvc sources to the https://github.com/helm/monocular and pulling in the built images from there. Now that the sources have been moved to that repo and the CI is building images, this PR removes the sources from this repo and updates the Helm charts and other documentation to reference the upstream images.

Commits have been separated for easier review of changes.

fixes #671

@@ -21,12 +21,3 @@ This proxy is written in Go. Check more details about the implementation in this
### Apprepository CRD and Controller

Chart repositories in Kubeapps are managed with a `CustomResourceDefinition` called `apprepositories.kubeapps.com`. Each repository added to Kubeapps is an object of type `AppRepository` and the `apprepository-controller` will watch for changes on those type of objects to update the list of available charts to deploy.

### `chart-repo`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need to maintain some docs saying that chart-repo and chartsvc are not here, why and point to the their documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, let me update this

@prydonius prydonius merged commit 69b1c0d into vmware-tanzu:master Oct 9, 2018
@prydonius prydonius deleted the remove-chart-repo-chartsvc branch October 9, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move chartsvc and chart-repo to Monocular repo
2 participants